Skip to content

Commit 24de90f

Browse files
committed
MC-5835: [Sec] XSS in Page Builder
Move category argument to addCategoryConditionToProductsBlock to its own data entity
1 parent ab785ff commit 24de90f

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/CommonContentTypeData.xml

+4
Original file line numberDiff line numberDiff line change
@@ -121,4 +121,8 @@
121121
<data key="fieldName">message</data>
122122
<data key="value">Magento1111111 Page11111111111</data>
123123
</entity>
124+
<!-- XSS Payload -->
125+
<entity name="PageBuilderXSSPayloadProperty" type="pagebuilder_xss_payload">
126+
<data key="value">&gt;&lt;img src=x onerror=throw(1)&gt;</data>
127+
</entity>
124128
</entities>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderProductsTest.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1394,7 +1394,7 @@
13941394
</actionGroup>
13951395
<actionGroup ref="addCategoryConditionToProductsBlock" stepKey="addCategory">
13961396
<argument name="page" value="ProductsContentTypeForm"/>
1397-
<argument name="category" value="&gt;&lt;img src=x onerror=throw(1)&gt;"/>
1397+
<argument name="category" value="{{PageBuilderXSSPayloadProperty.value}}"/>
13981398
</actionGroup>
13991399
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
14001400
<!-- Validate Stage -->

0 commit comments

Comments
 (0)