Skip to content

Commit 8a04730

Browse files
PB-1140: [PB][CLOUD] Page Builder Error popup appears
- fix static tests failures
1 parent 5624fc9 commit 8a04730

File tree

2 files changed

+53
-51
lines changed
  • app/code/Magento/PageBuilderAdminAnalytics/view/adminhtml/web/js/page-builder
  • dev/tests/js/jasmine/tests/app/code/Magento/PageBuilder/view/adminhtml/web/js/page-builder

2 files changed

+53
-51
lines changed

app/code/Magento/PageBuilderAdminAnalytics/view/adminhtml/web/js/page-builder/events-mixin.js

+52-50
Original file line numberDiff line numberDiff line change
@@ -3,54 +3,56 @@
33
* See COPYING.txt for license details.
44
*/
55

6-
define(['underscore', 'Magento_PageBuilderAdminAnalytics/js/page-builder/event-builder'],
7-
function (_, EventBuilder) {
8-
'use strict';
9-
10-
return function (target) {
11-
var originalTarget = target.trigger,
12-
isAdminAnalyticsEnabled,
13-
event,
14-
hasPageBuilderBeenUsed = false,
15-
delayedPush;
16-
17-
/**
18-
* Invokes custom code to track information regarding Page Builder usage
19-
*
20-
* @param {String} name
21-
* @param {Array} args
22-
*/
23-
24-
target.trigger = function (name, args) {
25-
originalTarget.apply(originalTarget, [name, args]);
26-
isAdminAnalyticsEnabled =
27-
!_.isUndefined(window.digitalData) &&
28-
!_.isUndefined(window._satellite);
29-
30-
if (!hasPageBuilderBeenUsed && name.indexOf('stage:fullScreenModeChangeAfter') !== -1 &&
31-
args.fullScreen && isAdminAnalyticsEnabled
32-
) {
33-
hasPageBuilderBeenUsed = true;
34-
window.digitalData.page.url = window.location.href;
35-
window.digitalData.page.attributes = {
36-
editedWithPageBuilder: 'true'
37-
};
38-
window._satellite.track('page');
39-
}
40-
41-
event = EventBuilder.build(name, args);
42-
43-
if (isAdminAnalyticsEnabled && !_.isUndefined(window.digitalData.event) && !_.isUndefined(event)) {
44-
delayedPush = setInterval(function (object) {
45-
if (_.isArray(window.digitalData.event)) {
46-
window.digitalData.event.push(object);
47-
window._satellite.track('event');
48-
clearInterval(delayedPush);
49-
}
50-
}, 500, event);
51-
}
52-
};
53-
54-
return target;
6+
define([
7+
'underscore',
8+
'Magento_PageBuilderAdminAnalytics/js/page-builder/event-builder'
9+
], function (_, EventBuilder) {
10+
'use strict';
11+
12+
return function (target) {
13+
var originalTarget = target.trigger,
14+
isAdminAnalyticsEnabled,
15+
event,
16+
hasPageBuilderBeenUsed = false,
17+
delayedPush;
18+
19+
/**
20+
* Invokes custom code to track information regarding Page Builder usage
21+
*
22+
* @param {String} name
23+
* @param {Array} args
24+
*/
25+
26+
target.trigger = function (name, args) {
27+
originalTarget.apply(originalTarget, [name, args]);
28+
isAdminAnalyticsEnabled =
29+
!_.isUndefined(window.digitalData) &&
30+
!_.isUndefined(window._satellite);
31+
32+
if (!hasPageBuilderBeenUsed && name.indexOf('stage:fullScreenModeChangeAfter') !== -1 &&
33+
args.fullScreen && isAdminAnalyticsEnabled
34+
) {
35+
hasPageBuilderBeenUsed = true;
36+
window.digitalData.page.url = window.location.href;
37+
window.digitalData.page.attributes = {
38+
editedWithPageBuilder: 'true'
39+
};
40+
window._satellite.track('page');
41+
}
42+
43+
event = EventBuilder.build(name, args);
44+
45+
if (isAdminAnalyticsEnabled && !_.isUndefined(window.digitalData.event) && !_.isUndefined(event)) {
46+
delayedPush = setInterval(function (object) {
47+
if (_.isArray(window.digitalData.event)) {
48+
window.digitalData.event.push(object);
49+
window._satellite.track('event');
50+
clearInterval(delayedPush);
51+
}
52+
}, 500, event);
53+
}
5554
};
56-
});
55+
56+
return target;
57+
};
58+
});

dev/tests/js/jasmine/tests/app/code/Magento/PageBuilder/view/adminhtml/web/js/page-builder/events-mixin.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,4 +61,4 @@ define([
6161
}, 1000);
6262
});
6363
});
64-
});
64+
});

0 commit comments

Comments
 (0)