Skip to content

Commit df2c8fe

Browse files
omiroshnichenkoomiroshnichenko
authored
Merge pull request #501 from magento-pangolin/3.0.0-RC3-1.4.0
[1.4.0-release] MQE-2113: fix errors reported by the static check
2 parents 94b5c41 + 49c6a28 commit df2c8fe

18 files changed

+9
-25
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/AdvancedConfigurationActionGroup/ValidateAdvancedStyleWithNoAlignmentEmptyBorderRadiusActionGroup.xml

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
<arguments>
1212
<argument name="page" defaultValue=""/>
1313
<argument name="border" defaultValue="PageBuilderAdvancedBorderPropertyNone"/>
14-
<argument name="borderRadius" defaultValue="PageBuilderAdvancedBorderRadiusDefaultProperty"/>
1514
<argument name="borderWidth" defaultValue="PageBuilderAdvancedBorderWidthPropertyDefault"/>
1615
<argument name="margin" defaultValue="PageBuilderMarginsPropertyDefault"/>
1716
<argument name="padding" defaultValue="PageBuilderPaddingPropertyDefault"/>

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/AdvancedConfigurationActionGroup/ValidateAdvancedStyleWithNoBorderWidthActionGroup.xml

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
<actionGroup name="validateAdvancedStyleWithNoBorderWidth">
1111
<arguments>
1212
<argument name="page" defaultValue=""/>
13-
<argument name="alignment" defaultValue="PageBuilderAdvancedAlignmentPropertyDefault"/>
1413
<argument name="border" defaultValue="PageBuilderAdvancedBorderPropertyNone"/>
1514
<argument name="borderRadius" defaultValue="PageBuilderAdvancedBorderRadiusDefaultProperty"/>
1615
<argument name="margin" defaultValue="PageBuilderMarginsPropertyDefault"/>

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeColumnActionGroup/DragColumnToAnotherColumnGroupActionGroup.xml

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
<arguments>
1212
<argument name="contentType" defaultValue="PageBuilderColumnContentType"/>
1313
<argument name="contentTypeIndex" defaultValue="1" type="string"/>
14-
<argument name="containerTargetType" defaultValue="PageBuilderColumnContentType"/>
1514
<argument name="containerTargetIndex" defaultValue="1" type="string"/>
1615
<argument name="x" defaultValue="10" type="string"/>
1716
<argument name="y" defaultValue="0" type="string"/>

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeHeadingActionGroup/EnterHeadingOnStageActionGroup.xml

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
<actionGroup name="enterHeadingOnStage">
1111
<arguments>
1212
<argument name="index" defaultValue="1" type="string"/>
13-
<argument name="headingText" defaultValue="PageBuilderHeadingTextProperty"/>
1413
<argument name="headingType" defaultValue="PageBuilderHeadingTypeDefaultProperty"/>
1514
<argument name="headingAlignment" defaultValue="PageBuilderHeadingAlignmentProperty_left"/>
1615
</arguments>

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeHeadingActionGroup/VerifyHeadingInStorefrontActionGroup.xml

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
1010
<actionGroup name="verifyHeadingInStorefront">
1111
<arguments>
12-
<argument name="page" defaultValue=""/>
1312
<argument name="headingType" defaultValue="PageBuilderHeadingTypeDefaultProperty"/>
1413
<argument name="headingText" defaultValue="PageBuilderHeadingTextProperty"/>
1514
<argument name="index" defaultValue="1" type="string"/>

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeHeadingActionGroup/VerifyHeadingInStorefrontWithAlignmentActionGroup.xml

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
1010
<actionGroup name="verifyHeadingInStorefrontWithAlignment">
1111
<arguments>
12-
<argument name="page" defaultValue=""/>
1312
<argument name="headingType" defaultValue="PageBuilderHeadingTypeDefaultProperty"/>
1413
<argument name="headingText" defaultValue="PageBuilderHeadingTextProperty"/>
1514
<argument name="alignment" defaultValue="PageBuilderAdvancedAlignmentPropertyLeft"/>

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeProductsActionGroup/ClickProductAddToWishListInContinuousProductsCarouselOnStorefrontActionGroup.xml

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
1010
<actionGroup name="clickProductAddToWishListInContinuousProductsCarouselOnStorefront">
1111
<arguments>
12-
<argument name="product" type="string"/>
1312
<argument name="productItemIndex" defaultValue="1" type="string"/>
1413
<argument name="productGroupIndex" defaultValue="1" type="string"/>
1514
</arguments>

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/ContentTypeVideoActionGroup/ValidateVideoPlayingActionGroup.xml

-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
</annotations>
1414
<arguments>
1515
<argument name="page" defaultValue="VideoOnStage"/>
16-
<argument name="url" defaultValue="PageBuilderVideoUrl_Empty"/>
1716
<argument name="index" defaultValue="1" type="string"/>
1817
</arguments>
1918
<waitForPageLoad stepKey="waitForPageLoad"/>

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/OptionsMenuActionGroup/HideSmallContentTypeActionGroup.xml

-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
<argument name="section"/>
1313
<argument name="contentType"/>
1414
<argument name="targetIndex" defaultValue="1" type="string"/>
15-
<argument name="x" defaultValue="null" type="string"/>
16-
<argument name="y" defaultValue="null" type="string"/>
1715
</arguments>
1816
<!-- Hiding content type -->
1917
<comment userInput="Hiding content type" stepKey="commentHideContentType"/>

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/OptionsMenuActionGroup/ShowSmallContentTypeActionGroup.xml

-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
<argument name="section"/>
1313
<argument name="contentType"/>
1414
<argument name="targetIndex" defaultValue="1" type="string"/>
15-
<argument name="x" defaultValue="null" type="string"/>
16-
<argument name="y" defaultValue="null" type="string"/>
1715
</arguments>
1816
<!-- Showing content type -->
1917
<comment userInput="Showing content type" stepKey="commentShowContentType"/>

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/WYSIWYGActionGroup/AddPageLinkWidgetToTinyMCE3ActionGroup.xml

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
1010
<actionGroup name="addPageLinkWidgetToTinyMCE3" extends="addPageLinkWidgetToTinyMCE">
1111
<arguments>
12-
<argument name="widget" defaultValue=""/>
1312
<argument name="page" defaultValue="" type="string"/>
1413
</arguments>
1514
<comment userInput="Adding Widget To TinyMCE3" stepKey="commentAddWidget"/>

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/WYSIWYGActionGroup/AddPageLinkWidgetToTinyMCEActionGroup.xml

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
1010
<actionGroup name="addPageLinkWidgetToTinyMCE">
1111
<arguments>
12-
<argument name="widget" defaultValue=""/>
1312
<argument name="page" defaultValue="" type="string"/>
1413
</arguments>
1514
<comment userInput="Adding Widget To Tiny MCE" stepKey="commentAddWidget"/>

‎app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/WYSIWYGActionGroup/DoubleClickWidgetTinyMCEActionGroup.xml

-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
<actionGroup name="doubleClickWidgetTinyMCE">
1111
<arguments>
1212
<argument name="section" defaultValue="TextOnStage"/>
13-
<argument name="index" defaultValue="1" type="string"/>
14-
<argument name="widget"/>
1513
</arguments>
1614
<waitForElementVisible selector="{{section.directive('1', TinyMCEWidgetCMSPageLink.editPanelValue)}}" stepKey="waitForWidgetVisible"/>
1715
<doubleClick selector="{{section.directive('1', TinyMCEWidgetCMSPageLink.editPanelValue)}}" stepKey="doubleClickOnWidgetPlaceholder"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCmsBlockVerifyCanDeleteContentTypesFromOnClickOptionMenusTest.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
<annotations>
1212
<features value="PageBuilder"/>
1313
<stories value="CMS Block"/>
14-
<title value="Verify that user can delete content types from on-hover option menus in CMS Block"/>
15-
<description value="This test is intended to ensure that users can delete content types from the on-hover option menus within the PageBuilder stage for CMS Block."/>
14+
<title value="Verify that user can delete content types from on-click option menus in CMS Block"/>
15+
<description value="This test is intended to ensure that users can delete content types from the on-click option menus within the PageBuilder stage for CMS Block."/>
1616
<severity value="CRITICAL"/>
1717
<useCaseId value="MC-3328"/>
1818
<testCaseId value="MC-13762"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCmsBlockVerifyCanDuplicateContentTypesFromOnClickOptionMenusTest.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
<annotations>
1212
<features value="PageBuilder"/>
1313
<stories value="CMS Block"/>
14-
<title value="Verify that user can duplicate content types from on-hover option menus in CMS Block"/>
15-
<description value="This test is intended to ensure that users can duplicate content types from the on-hover option menus within the PageBuilder stage for CMS Block."/>
14+
<title value="Verify that user can duplicate content types from on-click option menus in CMS Block"/>
15+
<description value="This test is intended to ensure that users can duplicate content types from the on-click option menus within the PageBuilder stage for CMS Block."/>
1616
<severity value="MAJOR"/>
1717
<useCaseId value="MC-3328"/>
1818
<testCaseId value="MC-13760"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCmsBlockVerifyCanEditContentTypesFromOnClickOptionMenusTest.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
<annotations>
1212
<features value="PageBuilder"/>
1313
<stories value="CMS Block"/>
14-
<title value="Verify that user can edit content types from on-hover option menus in CMS Block"/>
15-
<description value="This test is intended to ensure that users can edit content types from the on-hover option menus within the PageBuilder stage for CMS Block."/>
14+
<title value="Verify that user can edit content types from on-click option menus in CMS Block"/>
15+
<description value="This test is intended to ensure that users can edit content types from the on-click option menus within the PageBuilder stage for CMS Block."/>
1616
<severity value="BLOCKER"/>
1717
<useCaseId value="MC-3328"/>
1818
<testCaseId value="MC-13759"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminCMSBlockPageBuilderTest/PageBuilderCmsBlockVerifyCanEditContentTypesFromOnHoverOptionMenusTest.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
<annotations>
1212
<features value="PageBuilder"/>
1313
<stories value="CMS Block"/>
14-
<title value="Verify that user can move content types from on-hover option menus in CMS Block"/>
15-
<description value="This test is intended to ensure that users can move content types from the on-hover option menus within the PageBuilder stage for CMS Block."/>
14+
<title value="Verify that user can edit content types from on-hover option menus in CMS Block"/>
15+
<description value="This test is intended to ensure that users can edit content types from the on-hover option menus within the PageBuilder stage for CMS Block."/>
1616
<severity value="BLOCKER"/>
1717
<useCaseId value="MC-3328"/>
1818
<testCaseId value="MC-13751"/>

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderVideoTest/VideoValidateAutoplayDisabled.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<annotations>
1212
<features value="PageBuilder"/>
1313
<stories value="Video"/>
14-
<title value="Validate Video Autoplay Attribute"/>
14+
<title value="Validate Video Autoplay Attribute - Disabled"/>
1515
<description value="Validate that setting the autoplay attribute in the General form for Video will update the Stage and Storefront correctly."/>
1616
<severity value="BLOCKER"/>
1717
<useCaseId value="PB-375"/>

0 commit comments

Comments
 (0)