Open
Description
This issue is automatically created based on existing pull request: #804: Ignore styles which no longer apply
Description
When PageBuilder initialises, it moves styles from a <style> tag into data-{viewport}-styles
attributes. If there are CSS selectors that do not match any elements, an error is thrown:
This pull request fixes this bug.
Manual testing scenarios
- Use Magento import tool to set a product description (or other Page Builder-enabled attribute) which contains HTML, including some CSS that does not match any elements. (eg,
<span>Sample text</span><style>#not-found { color: red; }</style>
) - Navigate to this product in the admin.
- Witness that Page Builder fails to initialise for this field, and saving the product is impossible (due to a different JavaScript error which stems from the same root cause).
- Apply the changes in this pull request.
- Witness that Page Builder initialises as expected, and it is possible to save the product.
Checklist
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- All new or changed code is covered with unit/integration tests (if applicable)
- README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- All automated tests passed successfully (all builds are green)
Metadata
Assignees
Labels
Type
Projects
Status
Ready for Grooming