Community themes contain resources for Commerce edition modules

[clockworkgeek]

Summary (*)

The three standard themes have several folders which reference modules that do not exist in Community edition. They mostly contain _module.less files and this leads to unused style rules in the deployed CSS. Also it's a little bit annoying.

Examples (*)

The following folders are superfluous:

adminhtml/Magento/backend/Magento_AdvancedCheckout
adminhtml/Magento/backend/Magento_Banner
adminhtml/Magento/backend/Magento_CatalogPermissions
adminhtml/Magento/backend/Magento_CustomerBalance
adminhtml/Magento/backend/Magento_GiftCard
adminhtml/Magento/backend/Magento_GiftRegistry
adminhtml/Magento/backend/Magento_GiftWrapping
adminhtml/Magento/backend/Magento_Reward
adminhtml/Magento/backend/Magento_Rma
adminhtml/Magento/backend/Magento_VersionsCms
adminhtml/Magento/backend/Magento_VisualMerchandiser
frontend/Magento/black/Magento_AdvancedCheckout
frontend/Magento/black/Magento_Banner
frontend/Magento/black/Magento_CatalogEvent
frontend/Magento/black/Magento_GiftCard
frontend/Magento/black/Magento_GiftCardAccount
frontend/Magento/black/Magento_GiftRegistry
frontend/Magento/black/Magento_GiftWrapping
frontend/Magento/black/Magento_Invitation
frontend/Magento/black/Magento_MultipleWishlist
frontend/Magento/black/Magento_Rma
frontend/Magento/black/Magento_VersionsCms
frontend/Magento/luma/Magento_AdvancedCheckout
frontend/Magento/luma/Magento_CustomerBalance
frontend/Magento/luma/Magento_GiftCard
frontend/Magento/luma/Magento_GiftCardAccount
frontend/Magento/luma/Magento_GiftWrapping
frontend/Magento/luma/Magento_Invitation
frontend/Magento/luma/Magento_MultipleWishlist
frontend/Magento/luma/Magento_Reward
frontend/Magento/luma/Magento_Rma

Proposed solution

Move the mentioned resources to the appropriate theme or the modules' own view folders.

[magento-engcom-team]

Hi @clockworkgeek. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@clockworkgeek do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[magento-engcom-team]

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• Next steps are available in case you are a member of Community Maintainers.

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

Hi @clockworkgeek thank you for you report, this modules not deployed to frontend or adminhtml, if you recheck pub/static folder this files not exists.

[clockworkgeek]

Thank you @engcom-backlog-nazar for looking into this. LESS files are not static so will not be deployed to pub/static. They are copied to var/view_preprocessed and then compiled into styles.css, styles-m.css, and styles-l.css.

[magento-engcom-team]

✅ Confirmed by @engcom-backlog-nazar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98455, MAGETWO-98456 were created

Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.