Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "billing_regione" to "billing_region" #26681

Open
wants to merge 18 commits into
base: 2.4-develop
Choose a base branch
from
Open

Rename "billing_regione" to "billing_region" #26681

wants to merge 18 commits into from

Conversation

ageffray
Copy link

@ageffray ageffray commented Feb 3, 2020 •
edited by sdzhepa
Loading

Description (*)

On sales_order_create_customer_block.xml column for billing region is missnamed "billing_regione" instead of "billing_region"

Related Pull Requests

Fixed Issues (if relevant)

  1. fixes Billing_region field name on customer grid #26679: Billing_region field name on customer grid

Manual testing scenarios (*)

  1. On admin order creation in customer selection step
  2. Check that billing_region column is correctly fill

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 3, 2020

Hi @ageffray. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@rogyar
Copy link
Contributor

rogyar commented Feb 4, 2020

Hi @ageffray. Thank you for your collaboration. According to the Definition of done all changes introduced in a PR should be covered with automated tests.
Could I kindly ask you to cover your fix with MFTF test?

Thank you!

@rogyar rogyar self-assigned this Feb 4, 2020
@rogyar rogyar added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Feb 4, 2020
@engcom-Echo engcom-Echo self-assigned this Apr 13, 2020
@engcom-Echo @rogyar
Update dev/tests/integration/testsuite/Magento/Sales/Model/ResourceMo…
c76cbf7 
…del/Order/Customer/CollectionTest.php

Co-authored-by: Yaroslav Rogoza <[email protected]>
@rogyar
Copy link
Contributor

rogyar commented May 6, 2020

This PR contains backward-incompatible changes. I'm not sure about the possibility to deliver it within the scope of 2.4.0 (since we might have a code freeze at the moment).

@slavvka would you help, please, with the decision here?
Thank you.

@slavvka
Copy link
Member

slavvka commented May 7, 2020

@rogyar it is BIC even for 2.4.0 so it must be approved for 2.4.0 or 2.4.1

@rogyar
Copy link
Contributor

rogyar commented May 11, 2020

@slavvka thank you for your help. That makes sense.
@ageffray I'm putting your change on hold for the internal discussion. To sum up, the main reason of that is backward-incompatible changes that are not allowed in patch versions by default. The internal team needs to review such changes to make a final decision about the target version.

Thank you for understanding.

@ghost ghost added Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Priority: P3 May be fixed according to the position in the backlog. labels Jun 17, 2020
@engcom-Echo engcom-Echo added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Jul 16, 2020
gabrieldagama
gabrieldagama suggested changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@gabrieldagama gabrieldagama left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ageffray, can you fix the alias there as well? Thank you! Sorry for the delay in processing this.

@ghost ghost assigned gabrieldagama Oct 2, 2020
@engcom-Lima
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Lima
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Lima engcom-Lima removed the Issue: needs update Additional information is require, waiting for response label Jun 22, 2023
@engcom-Lima
Copy link
Contributor

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop and PHP 8.1

Manual testing scenario:

  • Apply these PR changes
  • On admin order creation in the customer selection step.
  • Check that the billing_region column is correctly filled.

After: ✔️
Country:
Screenshot 2023-06-22 at 12 47 24 PM
Region:
Screenshot 2023-06-22 at 12 47 32 PM

Builds are failed. Hence, moving this PR to Extended Testing.

@engcom-Lima engcom-Lima removed the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Jun 22, 2023
@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

@magento run Integration Tests,Functional Tests CE,Functional Tests B2B,Functional Tests EE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev left review comments

@gabrieldagama gabrieldagama Awaiting requested review from gabrieldagama

@rogyar rogyar Awaiting requested review from rogyar

Assignees

@ihor-sviziev ihor-sviziev

@rogyar rogyar

@gabrieldagama gabrieldagama

@engcom-Bravo engcom-Bravo

@engcom-Charlie engcom-Charlie

@engcom-Echo engcom-Echo

@engcom-Lima engcom-Lima

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Sales Component: Setup Event: MageCONF CD 2020 Priority: P3 May be fixed according to the position in the backlog. Progress: to approve Release Line: 2.4 Risk: high Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
Status: To Approve
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Billing_region field name on customer grid