Skip to content

[Issue] Making message lock release possible #29616

Open
@m2-assistant

Description

This issue is automatically created based on existing pull request: #26968: Making message lock release possible


Description (*)

Message can't be processed by the same consumer if it was rejected previuosly, beacause message lock is not released.
Example:
If we create dead-letter exchange (so far not possible using xml-s - see related PRs) we want our consumer to process the same message again later. It is not possible, because message is locked in db and we get exception here. It should be released here when message was rejected but it's not, because saving lock process create separate lock object, and one we pass as argument doesn't get populated with id.

I will fix test, as soon as solution will be accepted.

If PR will be accepted, please port to 2.3 as well.

Related Pull Requests

#26966
#26967

Manual testing scenarios (*)

  1. Publish message on queue
  2. Make consumer reject it
  3. Make consumer somehow consume it again (for example dead letter exchange)
  4. Message should be consumer and acked or rejected again, but not because of lock.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Labels

Component: MessageQueueIssue: Format is not validGate 1 Failed. Automatic verification of issue format is failedPriority: P3May be fixed according to the position in the backlog.Progress: PR in progressReported on 2.3.xIndicates original Magento version for the Issue report.Severity: S3Affects non-critical data or functionality and does not force users to employ a workaround.Triage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions