Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making message lock release possible #26968

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

Making message lock release possible #26968

wants to merge 1 commit into from

Conversation

bartoszkubicki
Copy link

@bartoszkubicki bartoszkubicki commented Feb 21, 2020 •
edited by m2-assistant bot
Loading

Description (*)

Message can't be processed by the same consumer if it was rejected previuosly, beacause message lock is not released.
Example:
If we create dead-letter exchange (so far not possible using xml-s - see related PRs) we want our consumer to process the same message again later. It is not possible, because message is locked in db and we get exception here. It should be released here when message was rejected but it's not, because saving lock process create separate lock object, and one we pass as argument doesn't get populated with id.

I will fix test, as soon as solution will be accepted.

If PR will be accepted, please port to 2.3 as well.

Related Pull Requests

#26966
#26967

Manual testing scenarios (*)

  1. Publish message on queue
  2. Make consumer reject it
  3. Make consumer somehow consume it again (for example dead letter exchange)
  4. Message should be consumer and acked or rejected again, but not because of lock.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Making message lock release possible #29616: Making message lock release possible

@m2-assistant
Copy link

m2-assistant bot commented Feb 21, 2020

Hi @bartoszkubicki. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@bartoszkubicki
Copy link
Author

I have reviewed failing checks. Db compare is ok, I don't know why it is red. Functional tests are failed in place that is not completly connected with PR

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 17, 2020
@sidolov
Copy link
Contributor

sidolov commented Aug 17, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Aug 17, 2020
Open
4 tasks
@bartoszkubicki
Copy link
Author

@sidolov what is the status of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: MessageQueue Priority: P3 May be fixed according to the position in the backlog. Progress: pending review Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Making message lock release possible
3 participants
@bartoszkubicki @sidolov @magento-engcom-team