-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub 31939 #31942
base: 2.4-develop
Are you sure you want to change the base?
GitHub 31939 #31942
Conversation
Hi @kanduvisla. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @kanduvisla, thank you for your contribution! |
Hi @kanduvisla. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. |
@magento run all tests |
I'm a bit puzzled here. Why are some tests failing of parts that I am not even touching with this PR? |
@magento run all tests |
@magento run Unit Tests, Functional Tests B2B |
Can anyone explain to me why my unit tests are failing? If I look at the Allure reports I see no errors, warnings, whatsover. Only 100% Success. For CE, EE and B2B. So why is it marked as failed? |
Description
This pull request fixes issue #31939 . See the ticket for more details.
Fixed Issues
Manual testing scenarios
$isInternal
-argument tofalse
.The admin notification is now stored only once.
Contribution checklist (*)