Skip to content

Virtual refunded orders do not persist closed state when comment is added via Admin #35283

Closed
@ksenia-zlotin

Description

I believe this is caused by the commit here:
4f90cf5
I would like an explanation why was this check added and how come even on a clean 2.4.3-p1 copy I am able to recreate this error?

Preconditions (*)

  1. Magento 2.4.3-p1
  2. PHP 7.4.13

Steps to reproduce (*)

  1. Install clean copy of Magento 2.4.3-p1 without sample data
  2. Create virtual product with a price of $10
  3. Place order with that product and invoice it in the Admin so that credit memo is possible
  4. Press the credit memo button and go ahead and create one
  5. In the

Screen Shot 2022-04-08 at 2 08 15 PM

order view loaded after the creditmemo saved, scroll to bottom of page where comments section status dropdown is

Expected result (*)

  1. The status dropdown should only show the 'Closed' option, that way when a comment is added to this closed order - it does not set it to 'Complete'.

Screen Shot 2022-04-07 at 11 26 00 AM

Actual result (*)

  1. order state is never set to closed when the refund saves successfully, while the status does update to closed in the db
  2. order status dropdown in comments section showing only 'Complete' option which will cause any new comment which will be added to revert the order status from 'Closed' to 'Complete'

Screen Shot 2022-04-08 at 2 08 20 PM

  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

Area: OrderComponent: order statusIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: doneReported on 2.4.3-p1Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions