Theme issue on setup:upgrade

[Nuranto]

Summary (*)

When performing a setup:upgrade, we get :

The following themes will be registered: adminhtml/Magento/blank, adminhtml/Hyva/reset, adminhtml/Magento/luma, adminhtml/Hyva/default
The following themes will be removed: frontend/Magento/blank, frontend/Magento/luma, frontend/Hyva/reset, frontend/Hyva/default

The issue is here :
app/code/Magento/Theme/Model/Theme.php

public function getArea()
    {
        // In order to support environment emulation of area, if area is set, return it
        if ($this->getData('area') && !$this->_appState->isAreaCodeEmulated()) {
            return $this->getData('area');
        }
        return $this->_appState->getAreaCode();
    }

The emulation of adminhtml is triggered in setup:upgrade by /var/www/html/vendor/magento/module-deploy/Console/Command/App/ConfigImportCommand.php(106)

Proposed solution

I can't see any usecase where a theme should return the current state area, so the better solution seems to be :

public function getArea()
    {
            return $this->getData('area');
    }

(or simply remove the whole function, and let the magic functions deal with it.)
Also, the appState should be removed from constructor.

Or if some reason I can't see, sometimes the area is not defined (imho this should not be permitted), we could keep the fallback like this :

public function getArea()
    {
          return $this->getData('area') ?: $this->_appState->getAreaCode();
    }

But it seems to me that this is a bad solution.

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users with no workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @Nuranto. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[Nuranto]

Here's a temporary patch, if it can helps someone :

--- a/Model/Theme.php
+++ b/Model/Theme.php
@@ -265,11 +265,7 @@
      */
     public function getArea()
     {
-        // In order to support environment emulation of area, if area is set, return it
-        if ($this->getData('area') && !$this->_appState->isAreaCodeEmulated()) {
-            return $this->getData('area');
-        }
-        return $this->_appState->getAreaCode();
+        return $this->getData('area');
     }
 
     /**

[mrtuvn]

https://github.com/magento/magento2/pull/32142/files#diff-208947a432c650d2473cbf3fddba5e294553440d52c2c7e87f67f35085909ff7
Added some works quite long ago here but i will consider cover your case too

[Nuranto]

Thanks @mrtuvn !

[m2-assistant]

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Delta]

Hi @Nuranto ,
Is this issue resolved ?

Thanks

[Nuranto]

Hi @engcom-Delta,

If you mean "Is the issue still present on latest 2.4", then yes, the issue is still there.

But @mrtuvn added a fix in his existing PR : #32142 cf423f3
and I confirm this solve the issue.