Unable to ship / notify ready for pickup when an MSI pickup order has some items refunded

[ArronKing]

Preconditions and environment

• 2.4.5
• MSI enabled with store pickup

Steps to reproduce

1. Setup an MSI store - "Warehouse" and "Store" as stock sources
2. Enable "Store" as pickup location
3. Create "Website" stock - "Warehouse" and "Store" as the stock sources, sales channel should be the website
4. Create 2 products, Product A - stock of 10 at "Store", Product B - stock of 10 at "Store"
5. Place an order on the frontend, ordering 10 x Product A and 10 x Product B. Make sure the order is a "pickup" from "Store"
6. Login as an admin, issue a refund on the order for Product A. And drop it's quantity to 0. (Simulating where Product A isn't actually in stock, we've only just realised so we'll refund the customer and correct stock level).
7. Try to Ship / "Notify Order is Ready for Pickup"

Expected result

Order is shipped, customer is notified. Shipment should only contain 10 x Product B as we've refunded Product A.

Actual result

Admin is told "The order is not ready for pickup" - unable to ship

Additional information

Exception is thrown from Magento\InventoryInStorePickupSales\Model\Order:57

Tracing that back, bug is in Magento\InventoryInStorePickupSales\Model\Order\IsFulfillable:77:

if (!$this->isItemFulfillable($item->getSku(), $sourceCode, (float)$item->getQtyOrdered())) {

That line checks if there's enough stock to fulfil the items quantity ordered. That shouldn't be the case, it needs to check on the level it needs to ship.

---

To workaround this issue you need to give Product A enough stock to pass this check.
When the shipment is created, product A isn't on the shipment (which is correct).
Then re-adjust Product A stock level

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @ArronKing. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[abdel-aouby]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @abdel-aouby. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @abdel-aouby, here is your Magento Instance: https://2844ba74e880a2bd89891bcae4a6eb7b.instances.magento-community.engineering
Admin access: https://2844ba74e880a2bd89891bcae4a6eb7b.instances.magento-community.engineering/admin_d3e5
Login: 94038753
Password: 86583b1f2a1f

[m2-assistant]

Hi @engcom-Alfa. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.

• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

@magento give me 2.4-develop instance with extensions magento/inventory

[magento-deployment-service]

Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Hotel, here is your Magento Instance: https://2844ba74e880a2bd89891bcae4a6eb7b.instances.magento-community.engineering
Admin access: https://2844ba74e880a2bd89891bcae4a6eb7b.instances.magento-community.engineering/admin_a4b6
Login: 270a2016
Password: 87436e41bbbd

[engcom-Alfa]

@magento give me 2.4-develop instance with extensions magento/inventory