Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#37895: Wishlist creating issue #38075

Closed
wants to merge 5 commits into from
Closed

magento/magento2#37895: Wishlist creating issue #38075

wants to merge 5 commits into from

Conversation

Alexander-Khohklov
Copy link
Contributor

-fixed issue Wishlist product added to cart without an error message also "The Wish List item can't load at this time. Please try again later."

Description (*)

redirect on the wishlist page with a success affter editted product added to cart from wishlist page.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Wishlist creating issue #37895

Manual testing scenarios (*)

  1. Login as a customer
  2. Add two products to wishlist
  3. Edit any one product - This will land you to PDP page.
  4. Add the product to the cart.
  5. It will redirect on the wishlist page with a success message,
    without "The Wish List item can't load at this time. Please try again later." error message.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@Alexander-Khohklov
magento#37895: Wishlist creating issue
4e5dd16 
-fixed issue Wishlist product added to cart without an error message also "The Wish List item can't load at this time. Please try again later."
@m2-assistant
Copy link

m2-assistant bot commented Oct 13, 2023

Hi @Alexander-Khohklov. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Perspective Team partners-contribution Pull Request is created by Magento Partner labels Oct 13, 2023
@m2-community-project m2-community-project bot added Priority: P3 May be fixed according to the position in the backlog. Progress: pending review labels Oct 13, 2023
@Alexander-Khohklov
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@sinhaparul sinhaparul added the Project: Community Picked PRs upvoted by the community label Oct 13, 2023
@shikhamis11
Copy link
Member

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@shikhamis11
Copy link
Member

@Alexander-Khohklov Thank you for your Pull Request. Can you also cover the changes with MFTF tests?

@Alexander-Khohklov
Copy link
Contributor Author

@magento run Integration Tests, Functional Tests EE, Functional Tests CE, Sample Data Tests EE, Sample Data Tests CE, Sample Data Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Hotel engcom-Hotel self-requested a review October 20, 2023 10:12
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Hotel
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

engcom-Hotel
engcom-Hotel requested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Alexander-Khohklov,

Thanks for the contribution!

In accordance with DOD, please cover the changes with some automated tests.

Thanks

@engcom-Charlie engcom-Charlie self-assigned this Oct 30, 2023
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Charlie
Copy link
Contributor

@magento give me test instance

@magento-deployment-service Magento Deployment Service
Copy link

Hi @engcom-Charlie. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service Magento Deployment Service
Copy link

Hi @engcom-Charlie, here is your Magento Instance: https://e151ecd8616a4ddcc1a97bfe64177f46.instances-prod.magento-community.engineering
Admin access: https://e151ecd8616a4ddcc1a97bfe64177f46.instances-prod.magento-community.engineering/admin_0f23
Login: ef143440
Password: 76fb95fcee6b

@engcom-Charlie
Copy link
Contributor

Hi @Alexander-Khohklov,

Thank you for your contribution!

In order to work on the test coverage, I I tried to reproduce this issue on magento 2.4 develop. It seems that the issue is not reproducible now.

Steps followed to reproduce the issue:

  1. Login as a customer
  2. Add two products to wishlist
  3. Edit any one product - This will land you to PDP page.
  4. Add the product to the cart.
  5. Here, It is keeping the user on PDP page only with a success message and not redirecting it to wishlist page back hence ultimately we cant see any error message as mentioned in linked issue.

Can you please re-check the issue if its still reproducible or please let us know if I am missing anything here.

Thank you!

@engcom-Charlie
Copy link
Contributor

Hi @Alexander-Khohklov,

Thank you for your contribution!

As per this comment, the issue is not reproducible. Please check once and confirm till then moving this PR in On Hold.

Thank you!

@engcom-Charlie
Copy link
Contributor

As per this comment, the issue is not reproducible hence closing this PR now.

Please feel free to reopen in case of any updates.

@Alexander-Khohklov
Copy link
Contributor Author

@magento give me test instance

@magento-deployment-service Magento Deployment Service
Copy link

Hi @Alexander-Khohklov. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service Magento Deployment Service
Copy link

Hi @Alexander-Khohklov, here is your Magento Instance: https://e151ecd8616a4ddcc1a97bfe64177f46.instances-prod.magento-community.engineering
Admin access: https://e151ecd8616a4ddcc1a97bfe64177f46.instances-prod.magento-community.engineering/admin_fb7f
Login: a0fd7d52
Password: 2368fc223101

@Alexander-Khohklov
Copy link
Contributor Author

@magento give me 2.4.6-p3 test instance

@magento-deployment-service Magento Deployment Service
Copy link

Hi @Alexander-Khohklov. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service Magento Deployment Service
Copy link

Hi @Alexander-Khohklov, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel requested changes

Assignees

@engcom-Charlie engcom-Charlie

@engcom-Hotel engcom-Hotel

Labels
Partner: Perspective Team partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Project: Community Picked PRs upvoted by the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wishlist creating issue
7 participants
@Alexander-Khohklov @shikhamis11 @engcom-Hotel @engcom-Charlie @sinhaparul @m2-github-services @engcom-Echo