Attribute source issue

[Nuranto]

Preconditions and environment

• Magento version 2.4.6-p3

Steps to reproduce

1. Create attribute, dropdown, custom source model with : [0 => ['value' => 1, 'label' => 'option A'], 1 => ['value' => 2, 'label' => 'option B']
2. Create/save a product with attribute = Option A (value saved = 1)
3. Change your source model to remove first option
4. dump $attribute->getOptionText($product->getData('attribute'))

Expected result

Dumps null or false

Actual result

Dumps array :

['value' => 2, 'label' => 'option B']

Additional information

Use case :
It can happens quite easily with dynamic attribute source (when source options are managed via an UI for example)

Problem :

magento2/app/code/Magento/Eav/Model/Entity/Attribute/Source/AbstractSource.php

Lines 65 to 81 in 9e2eb99

	public function getOptionText($value)
	{
	$options = $this->getAllOptions();
	// Fixed for tax_class_id and custom_design
	if (count($options) > 0) {
	foreach ($options as $option) {
	if (isset($option['value']) && $option['value'] == $value) {
	return $option['label'] ?? $option['value'];
	}
	}
	}
	// End
	if (is_scalar($value) && isset($options[$value])) {
	return $options[$value];
	}
	return false;
	}

Fix could be :
if (is_scalar($value) && isset($options[$value]) && is_scalar($options[$value])) {
instead of
if (is_scalar($value) && isset($options[$value])) {

Or maybe remove that whole if : I don't understand why it exists.

Note : In my case, this issue crashed catalogsearch_fulltext reindex, leaving categories empty of products of frontend (but I'm using smile/elasticsuite)

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @Nuranto. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hello @Nuranto,

Thank you for the report and collaboration!

We tried to reproduce this on 2.4-develop, but it was not reproducible in our case.
Please take a look at the screenshots below:
When Option A is present in the source model, we got the correct label.

When Option A was removed from the source model, we got empty string and not the array.

Please find the attached custom module used to reproduce this issue and let us know if we are missing anything.
AttVendor.zip

Thank you.

[Nuranto]

Hello @engcom-November,

Sorry, my example was incomplete, you should either add a third option, or set value = 0 to option A

[engcom-November]

Hello @Nuranto,

Thank you for the quick reply!

We were able to reproduce this issue on 2.4-develop.
As you suggested we changed the value of Option A to 0 and it was reproducible.
Please take a look at the screenshot below:
When Option A with value 0 is removed we got the array as result.

Hence confirming the issue.

Please find the attached module used to reproduce this issue.
AttVendor.zip

Thank you.