Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronise store attributes if attribute scope is website #38311

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

simsComputing
Copy link

This pull request aims at fixing [https://github.com//issues/38243](this issue).
It fixes the synchronisation of a website scoped attribute in a multi store environment.

Description (*)

I fixed the issue by applying another condition in the _updateAttribute method of the Magento\Catalog\Model\ResourceModel\AbstractResource class.

A fix made recently on this method brought the bug. This method used to only call the _saveAttributeValue method of that same class. Now it has its own logic is the updated attribute is not new. I added a condition that the updated attribute must not be website scoped in a multi store environment.

I did not want to add too much code since the modificatoins that were made on this method took place for a specific reason that i do not know.

Fixed Issues (if relevant)

  1. Fixes _updateAttribute function started to behave incorrectly when trying to update an attribute which is on a website scope. #38243

Manual testing scenarios (*)

  1. Create 3 stores, each one of then will have their own store view.
  2. Create a Yes/No attribute with the website scope.
  3. Add this attribute to the default attribute set
  4. Create a simple product, set this Yes/No attribute to false on the scope of a store view.
  5. In a custom script :
$product = $this->productRepository->get('some-product-sku', false, 1);
$product->addAttributeUpdate('show_discount', 1, $product->getStoreId());

Adapt the sku and the store id to you use case.

  1. Check in the DB, the attribute should have the value "1" for all stores. If not, my fix does not work.

Questions or comments

It doesn't seem i could write an automated test for this use case. Do you confirm ?
I took time to choose the right approach. I could not rollback the changes that were made on the issue at the origin of this bug even though the code written did not take into account the scope of the attribute.
So i decided to treat only the very issue I was working on. I had to make so that previous work would still be present and this issue would be fixed.

I hope you agree with that approach.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Dec 22, 2023

Hi @simsComputing. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review labels Dec 22, 2023
@simsComputing
Copy link
Author

@magento run all tests

Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@simsComputing
Copy link
Author

@magento run Functional Tests CE

Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@simsComputing
Copy link
Author

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE

Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
None yet
2 participants