Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update admin configuration visibility #33361

Conversation

ravi-chandra3197
Copy link
Contributor

@ravi-chandra3197 ravi-chandra3197 commented Jun 26, 2021

Description (*)

update admin configuration as admin configuration tab not visible website and store wise

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. N/A

Questions or comments

  1. Issue summary
    Admin configuration is a global level configuration so security configuration is not visible on the website and store wise, This PR remove security configuration to show in website and store as the admin section is not allowed to set configuration website wise.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] update admin configuration visibility #38300: update admin configuration visibility

@m2-assistant
Copy link

m2-assistant bot commented Jun 26, 2021

Hi @ravi-chandra3197. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ravi-chandra3197
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Jun 26, 2021
@ihor-sviziev ihor-sviziev self-assigned this Jun 26, 2021
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved.

Failing tests look not related to changes from this PR.

@Den4ik
Copy link
Contributor

Den4ik commented Jun 26, 2021

@magento run Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Alfa
Copy link
Contributor

Hi @ravi-chandra3197 Thanks for your contribution!
This PR has no details about the issue at all. Kindly provide me the below details in order to process it please.

  1. Issue summary
  2. Detailed description about the issue
  3. Detailed steps to reproduce the issue
  4. Expected result
  5. Actual result
  6. Any additional information if you can provide along with screenshots as such please

Thanks in advance!

@sdzhepa sdzhepa added the Priority: P3 May be fixed according to the position in the backlog. label Nov 4, 2021
@ravi-chandra3197
Copy link
Contributor Author

Hello @engcom-Alfa
Admin configuration is a global level configuration so security configuration is not visible on the website and store wise, This PR remove security configuration to show in website and store as the admin section is not allowed to set configuration website wise.
Here is the ref. snapshot for the same.
Configuration-Settings-Stores-Magento-Admin (1)

@ravi-chandra3197
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ravi-chandra3197
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

Pull Requests are not mergeable to the mainline. Please merge the latest mainlines to your Pull Requests and restart the builds.

@engcom-Delta
Copy link
Contributor

@ravi-chandra3197 , Please resolve the conflicts on the PR to proceed further.

Thanks,

@engcom-Delta
Copy link
Contributor

@magento create issue

@ravi-chandra3197
Copy link
Contributor Author

@magento run all tests

@engcom-Bravo
Copy link
Contributor

Hi @ravi-chandra3197,

Thanks for your contribution.

We have verified the issue in Latest 2.4-develop instance and the issue is no more reproducible.Please refer the screenshot.

Screenshot 2024-06-13 at 11 58 00

Hence We are closing this PR please feel free to reopen the PR.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Issue: needs update Additional information is require, waiting for response Priority: P3 May be fixed according to the position in the backlog. Risk: low Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] update admin configuration visibility
7 participants