Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CDATA to catalog/catalog/fields_masks field comments #39069

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

Added CDATA to catalog/catalog/fields_masks field comments #39069

wants to merge 1 commit into from

Conversation

pedromtalavera
Copy link

Added CDATA to Product Fields Auto-Generation Mask fields comments

The change adds CDATA to the <comment> xml tag to correctly display the field_masks group field comments

Description (*)

Adds CDATA to the <comment> xml tag for the mask fields to properly escape the text containing curly brackets, like
{{name}} {{sku}}

Related Pull Requests

Fixed Issues

  1. Fixes Comment in store configuration is not showing properly missing {{name}} in catalog/catalog/fields_masks #38531

Manual testing scenarios (*)

  1. Go to Stores -> Configuration -> Catalog -> Catalog -> Product Fields Auto-Generation
  2. The comments for the Mask for SKU, Mask for Meta Title, Mask for Meta Keywords and Mask for Meta Description fields now show the correct text.
    image

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Aug 20, 2024

Hi @pedromtalavera. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added Priority: P3 May be fixed according to the position in the backlog. Progress: pending review labels Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comment in store configuration is not showing properly missing {{name}} in catalog/catalog/fields_masks
1 participant
@pedromtalavera