Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure the widget chooser saves the cms block id in the widget parameter #38868

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from
Open

Ensure the widget chooser saves the cms block id in the widget parameter #38868

wants to merge 2 commits into from

Conversation

digitalrisedorset
Copy link
Contributor

@digitalrisedorset digitalrisedorset commented Jun 25, 2024 •
edited
Loading

Ensure the widget chooser saves the cms block id in the widget parameter

Description (*)

The widget chooser selects the block identifier from the grid data that are displayed within the widget chooser ui. The first column is the block id. Therefore, the PR change consists in stopping the chooser to move the dom using the next() javascript method to set the widget parameter information

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes CMS Static Block Widget saves the block identifier instead of block ID #38801

Manual testing scenarios (*)

  1. Create a new cms block
    Create a new cms widget
    Assign the newly cms block to the widget
    Save the widget
    Check in the database the block id is assigned to the widget data
  2. Select an existing cms widget that has a blcok title in the data
    Select a new cms block for the widget
    Save the widget
    Check in the database the block id is assigned to the widget data

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Jun 25, 2024

Hi @digitalrisedorset. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review labels Jun 25, 2024
@digitalrisedorset digitalrisedorset changed the title Ensure the widget chooser selects the block id column rather than another column Ensure the widget chooser saves the cms block id in the widget parameter Jun 25, 2024
@digitalrisedorset
Copy link
Contributor Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMS Static Block Widget saves the block identifier instead of block ID
1 participant
@digitalrisedorset