Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Magento reorder order id issue #39399

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from
Open

Fixed Magento reorder order id issue #39399

wants to merge 2 commits into from

Conversation

magentoabu
Copy link

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes v2.4.7-p1 Magento reorder -1 order numbers #39089

Manual testing scenarios (*)

  1. Open any order, click reorder
  2. Submit the order.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Nov 25, 2024

Hi @magentoabu. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Nov 25, 2024
@magentoabu
Copy link
Author

@magento run all tests

@magentoabu
Copy link
Author

@magento run Static Tests, Integration Tests, Functional Tests EE, Functional Tests CE, Functional Tests B2B

@Priyakshic Priyakshic added the Project: Community Picked PRs upvoted by the community label Jan 15, 2025
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel engcom-Hotel self-requested a review January 17, 2025 11:38
engcom-Hotel
engcom-Hotel requested changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @magentoabu,

Thanks for the contribution!

Please sign the CLA as it is required to process the PR further. Till the time we are moving this PR On Hold.

Thanks

@magentoabu
Copy link
Author

Hello @magentoabu,

Thanks for the contribution!

Please sign the CLA as it is required to process the PR further. Till the time we are moving this PR On Hold.

Thanks

CLA signed, please proceed further

@magentoabu
Copy link
Author

@magento run Static Tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel requested changes

Assignees
No one assigned
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: on hold Project: Community Picked PRs upvoted by the community
Projects
Community Dashboard
Status: On Hold
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2.4.7-p1 Magento reorder -1 order numbers
3 participants
@magentoabu @engcom-Hotel @Priyakshic