Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpack object arguments as named parameters #37411

Open
wants to merge 5 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

ilnytskyi
Copy link
Contributor

@ilnytskyi ilnytskyi commented Apr 21, 2023

Description (*)

Just a code clean up that uses PHP 8.1 feature of unpacking array with named params.
So array_values call is not needed anymore. Probably improve overrall performance by 0.01 :D as many objects will instantiate faster

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Named argumaents are actualy a bit faster based on simple check for instantiatin 100 000 objects like this
https://pastebin.com/DGdBwwzN
Selection_177

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Unpack object arguments as named parameters #39233: Unpack object arguments as named parameters

@m2-assistant
Copy link

m2-assistant bot commented Apr 21, 2023

Hi @ilnytskyi. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@ilnytskyi
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ilnytskyi
Copy link
Contributor Author

OMG wow why would unit test check config with not existing parameters for requested type and allow test to pass?
\Magento\Framework\ObjectManager\Test\Unit\Factory\Fixture\Compiled\SimpleClassTesting::__construct

Shouldn't OM work this way that it reads config from di.xml and/or resolves based on reflection then just passes the unpack arguments to new $instance(...$args).
I you defined extra arguments in di.xml looks like they are ignored now, but this test failure would confirm that di compilation must fail for this case due to invalid di.xml. This way di.xml becomes stricter.

There were 2 errors:

1) Magento\Framework\ObjectManager\Test\Unit\Factory\CompiledTest::testCreateSimple
Error: Unknown named parameter $value_array

2) Magento\Framework\ObjectManager\Test\Unit\Factory\CompiledTest::testCreateSimpleConfiguredArguments
Error: Unknown named parameter $value_array

@ihor-sviziev ihor-sviziev self-assigned this Apr 24, 2023
@ihor-sviziev ihor-sviziev added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Area: Performance and removed Progress: review labels Apr 24, 2023
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix failing tests

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Apr 24, 2023

@ilnytskyi I think it was working like that in the pre-php8 era, so it kept like that due to compatibility reasons (earlier it was working by argument position, not by argument name, and you might have the wrong argument name).
So I think that was a hack, that we should remove to get performance benefit.
Please investigate deeper test failures

@ilnytskyi
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests EE, Integration Tests, WebAPI Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Lima engcom-Lima added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label May 11, 2023
@engcom-Dash engcom-Dash self-assigned this Sep 24, 2024
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

Hi @ilnytskyi

Thanks for the contribution!

✔️ QA Passed
Preconditions:

Install fresh Magento 2.4-develop

Steps to reproduce

  • Follow the description.
  • Run the following commands:
    bin/magento setup
    bin/magento s:d:c
    bin/magento c:f
    (All commands should run successfully.)

Before: ✖️
N/A

After✔️:
image

Execution of Array Values and Named Values.
image

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks

@engcom-Dash
Copy link
Contributor

@magento run Unit Tests, Functional Tests EE, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Dash
Copy link
Contributor

@magento create issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Performance Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Status: Merge in Progress
Development

Successfully merging this pull request may close these issues.

[Issue] Unpack object arguments as named parameters
4 participants