Skip to content

[Developer Experience] PHPDoc and Typo #39376

Open
@wubinworks

Description

@wubinworks

Summary

Confirmed on Magento 2.4.x

Issue 1:

PHPDoc

Issue 2:

Typo

See Examples.

Examples

Links are for Branch: 2.4.8-beta1

Issue 1:

\Magento\Framework\App\ScopeResolver#L13

/**
 * @var \Magento\Store\Model\StoreManagerInterface
 */
protected $objectManager;

should be

/**
 * @var ObjectManagerInterface
 */
protected $objectManager;

Issue 2:

\Magento\LoginAsCustomer\Model\GetLoggedAsCustomerAdminId#L38

return (int)$this->session->getLoggedAsCustomerAdmindId();
                                                    ^ extra d

\Magento\LoginAsCustomer\Model\SetLoggedAsCustomerAdminId#L38

$this->session->setLoggedAsCustomerAdmindId($adminId);
                                        ^ extra d

Proposed solution

See above.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

Metadata

Metadata

Assignees

Labels

Area: FrameworkComponent: LoginAsCustomerIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: dev in progressReported on 2.4.xIndicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchTriage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions