Skip to content

[Issue] Typecast incrementId variables always to a string #39458

Open
@m2-assistant

Description

This issue is automatically created based on existing pull request: #39452: Typecast incrementId variables always to a string


Description (*)

Ensure our calls to the sales_order table for the increment_id field are called with a string type and not an int type. When a module passed through an int variable, a full table scan occurs since the increment_id index can not be utilized.

Manual testing scenarios (*)

Create a small module and call the loadByIncrementId with an integer and see that this query is not hitting any index without this change.

Metadata

Assignees

Labels

Area: CatalogComponent: SalesIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: PR in progressReported on 2.4.xIndicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchTriage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it

Type

No type

Projects

  • Status

    Ready for Development

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions