[Issue] Update File.php

[m2-assistant]

This issue is automatically created based on existing pull request: #39454: Update File.php

---

Throwing an exception is removed.

Description (*)

When reading a file line by line, PHP ALWAYS returns false when reading the whole file. So the current driver code ALWAYS throws an exception. It should not work this way, the end of the file should not throw an exception.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @IlyaZha,

Thanks for the report and collaboration!

We have gone through with the codebase as well as the PR created by you. I agree with your point here but I would suggest you check the EOF using the below code:

if (feof($resource)) {
    return ''; // or handle end of file appropriately
}
$result = @stream_get_line($resource, $length, $ending);
if (false === $result) {
    throw new FileSystemException(
        new Phrase('File cannot be read %1', [$this->getWarningMessage()])
    );
}

Instead of removing the if condition. Confirming the issue for further processing.

Thanks