Magento\Framework\Filesystem\Driver\Http depends on reason phrase OK

[jirichmiel]

Summary

Method Magento\Framework\Filesystem\Driver\Http::isExists that determines whether given url exists depends on that remote server returns status header with 200 OK (e.g: HTTP/1.1 200 OK), but reason phrase OK is not required (https://www.rfc-editor.org/rfc/rfc7230#section-3.1.2). Some server may return only HTTP/1.1 200. In that case Driver\Http will tell that given url does not exist although it exists.

Examples

~$ curl -i "https://acs4.editionguard.com/fulfillment/URLLink.acsm"
HTTP/1.1 200 
Content-Type: application/vnd.adobe.adept+xml
Date: Wed, 15 Jan 2025 18:49:25 GMT
Server: Apache/2.4.39 (Amazon) OpenSSL/1.0.2k-fips
Content-Length: 139
Connection: keep-alive

Proposed solution

Change line from

return !(strpos($status, '200 OK') === false);

to

return !(strpos($status, '200') === false);

Release note

No response

Triage and priority

• < ] Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• [ > Severity: S4 - Affects aesthetics, professional look and feel, "quality" or "usability".

[m2-assistant]

Hi @jirichmiel. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @jirichmiel,

Thanks for the report and collaboration!

We have reviewed the codebase here:

magento2/lib/internal/Magento/Framework/Filesystem/Driver/Http.php

Lines 29 to 37 in e586f40

	public function isExists($path)
	{
	$headers = array_change_key_case(get_headers($this->getScheme() . $path, 1), CASE_LOWER);
	$status = $headers[0] ?? '';
	/* Handling 301 or 302 redirection */
	if (isset($headers[1]) && preg_match('/30[12]/', $status)) {
	$status = $headers[1];
	}

And also went through the link here and found that it does not necessarily return 200 OK, hence confirming this issue. I also suggest you to raise a community PR with this fix.

Thanks

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13725 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.