Open
Description
This issue is automatically created based on existing pull request: #39581: [PHPDOC] Fix bad phpdoc Magento\Framework\DB\Adapter\AdapterInterface::quoteColumnAs()
Description (*)
This PR fix the bad phpdoc for \Magento\Framework\DB\Adapter\AdapterInterface::quoteColumnAs()
.
The argument $alias
can be null
or string
.
Here is an example where the type null is used :
magento2/app/code/Magento/Catalog/Model/ResourceModel/Product/Collection.php
Lines 2557 to 2562 in d06337a
Related Pull Requests
None
Fixed Issues (if relevant)
None
Manual testing scenarios (*)
Setup PHPSTAN with level 5 or higher and run check.
Questions or comments
The quality of Magento code needs to be improved so that it is easier to use the code quality tools (phpstan, rector, ...) ❤️
Contribution checklist (*)
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- All new or changed code is covered with unit/integration tests (if applicable)
- README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- All automated tests passed successfully (all builds are green)
Metadata
Assignees
Labels
No labels
Activity