Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added app isolation attribute to tests in EavSetupTest #39617

Open
wants to merge 2 commits into
base: 2.4-develop
Choose a base branch
from
Open

Added app isolation attribute to tests in EavSetupTest #39617

wants to merge 2 commits into from

Conversation

stollr
Copy link
Contributor

@stollr stollr commented Feb 11, 2025

Description (*)

The proposed changes add AppIsolation attributes to two tests of the EavSetupTest, because they affect global state (adding error messages to the Magento\Eav\Model\Validator\Attribute\Code service) which will affect further tests that try to add EAV attributes.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes [IntegrationTests] Tests in EavSetupTest affect global state #39616.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Feb 11, 2025

Hi @stollr. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@stollr stollr mentioned this pull request Feb 11, 2025
Open
4 tasks
@engcom-Hotel engcom-Hotel added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it labels Feb 11, 2025
@stollr
Copy link
Contributor Author

stollr commented Feb 12, 2025

@magento run all tests

1 similar comment
@stollr
Copy link
Contributor Author

stollr commented Feb 13, 2025

@magento run all tests

@ihor-sviziev ihor-sviziev requested a review from Copilot February 13, 2025 15:36
Copilot
Copilot AI reviewed Feb 13, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • dev/tests/integration/testsuite/Magento/Eav/Setup/EavSetupTest.php: Language not supported
@stollr
Added app isolation attribute to tests in EavSetupTest
f9cd5fa 
because the affect global state (adding error messages to the `Magento\Eav\Model\Validator\Attribute\Code` service) which will affect further tests that try to add eav attributes.

This change fixes magento#39616.
@stollr
Fixed code style issues in EavSetupTest
fa649ae
@stollr stollr mentioned this pull request Feb 24, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[IntegrationTests] Tests in EavSetupTest affect global state
2 participants
@stollr @engcom-Hotel