CosmicString still not properly fixed in 2.4.8-p3

[adamlavery]

Preconditions and environment

• CE2.4.8-p3

Steps to reproduce

Run command encryption:key:change

Expected result

A new key is generated like:

    'crypt' => [
        'key' => 'base64bl3KKXTaxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxJaePm6wFw='
    ],

Actual result

Key is added to existing keys:

    'crypt' => [
        'key' => 'a92c7xxxxxxxxxxxxxxxxxxxxdf6405
a0faa2xxxxxxxxxxxxxxxxxxxxxxb8a09c4
base64bl3KKXTxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxJaePm6wFw='
    ],

Additional information

When we applied the fix for CosmicString (2.4.6), including rotating keys, we were left with an env file looking like:

    'crypt' => [
        'key' => 'a92c7xxxxxxxxxxxxxxxxxxxxdf6405
a0faa2xxxxxxxxxxxxxxxxxxxxxxb8a09c4
    ],

At the time there was no clear explanation why we apparently had two keys when using admin to change the key; everything says there should just be one. Some observers thought it needed to keep the old to stop things breaking. The site has been repeatedly hacked via hidden CMS block injection since applying the "fix".

Now we're on 2.4.8-p3, key rotation is still not behaving as expected. It adds to existing keys instead of actually rotating it. If we remove the old keys so there's just a single new key, all looks good until we fully clear caches (including view_preprocessed, page_cache and cache). Then Stripe stops working. No errors in browser, server or Magento logs - just no Stripe payment option. Restore previous keys and it works again. Only thing we see is multiple errors like the following when adding products to cart:

Could not retrieve customer profile: Warning: Attempt to read property "customers" on null in .../vendor/stripe/module-payments/Model/StripeCustomer.php on line 315

1. How do we properly fix CosmicString without breaking our site?
2. Why does encryption:key:change add another key instead of changing/rotating as documented?

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @adamlavery. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hi @adamlavery,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are able to reproduce the issue.Key is added to existing keys.Hence Confirming the issue.

Thanks.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-15971 is successfully created for this GitHub issue.