-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Issue] Fixed media folder symlinks #40839
Copy link
Copy link
Open
Labels
Issue: ready for confirmationReported on 2.4.xIndicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Triage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject itIssue related to Developer Experience and needs help with Triage to Confirm or Reject it
Metadata
Metadata
Assignees
Labels
Issue: ready for confirmationReported on 2.4.xIndicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Triage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject itIssue related to Developer Experience and needs help with Triage to Confirm or Reject it
Type
Fields
Give feedbackNo fields configured for issues without a type.
Projects
StatusShow more project fields
Ready for Confirmation
This issue is automatically created based on existing pull request: #40837: Fixed media folder symlinks
Description (*)
The new validation gives errors when a situation uses atomic deployments where the media folder is set as a shared folder.
Given some debugging, we can see that the
$quoteResolvedpath resolves the symlink:/home/www/example.com/shared/pub/media/custom_options/quoteWhile the
$mediaDirectory->getAbsolutePath()does not resolve symlinks:/home/www/example.com/releases/000/pub/media/By wrapping it in realPath we force it to resolve those symlinks and we end up comparing
/home/www/example.com/shared/pub/media/custom_options/quoteto/home/www/example.com/shared/pub/media/which is what we want to see in situations with a symlinkManual testing scenarios (*)
Invalid file path.error gets throw.Contribution checklist (*)