[ACP2E-4995] normalizeHeader() strips hyphens — year ranges like 2024-2026 may cause false copyright mismatch in CI

[kapil971390]

Hi team

While reviewing the recent changes in ACP2E-4995 (.github/scripts/check_copyright_pr.php), I noticed a normalization behavior that may be worth validating.

Observation

The normalizeHeader() implementation removes hyphens during comparison:

return strtolower((string) preg_replace('/[\s#/*-<>!?[]]+/', '', $text));

This means copyright headers containing year ranges such as:

Copyright © 2024-2026 Adobe

are normalized differently than headers that use a single year format.

Question

Can maintainers confirm that:

• buildExpectedHeader()
• extractCopyrightBlock()

always produce equivalent normalized output for valid copyright formats, including year ranges such as 2024-2026?

Suggested Verification

1. Create a file containing:

Copyright © 2024-2026 Adobe
All Rights Reserved.

2. Modify the file in a PR without changing the copyright block.

3. Run check_copyright_pr.php.

4. Verify the existing-file validation path does not incorrectly report a copyright mismatch.

Potential Impact

If different valid copyright formats normalize differently between the expected-header path and extracted-header path, CI could reject valid PRs with a copyright validation error.

Diff analyzed: 9c5a46f → 9b09c80

[m2-assistant]

Hi @kapil971390. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-17296 is successfully created for this GitHub issue.