Skip to content

Commit 812105a

Browse files
glo85315rudraswamy.cglo82145glo11372
authored
PWA-3233 : Unable to sign-In using TAB/ Mouse Click button from Sign … (#4231)
* PWA-3233 : Unable to sign-In using TAB/ Mouse Click button from Sign in Page * PWA-3233 :fixed the preetier issues * PWA-3233 : fixed test case coverage * PWA-3233 : fixed test case coverage * Update useSignIn.js * replacing handleTrigger with handleTriggerClick --------- Co-authored-by: rudraswamy.c <[email protected]> Co-authored-by: Aanchal Pawar <[email protected]> Co-authored-by: glo11372 <[email protected]>
1 parent d8f7e84 commit 812105a

File tree

2 files changed

+27
-9
lines changed

2 files changed

+27
-9
lines changed

packages/peregrine/lib/talons/SignIn/__tests__/useSignIn.spec.js

+14
Original file line numberDiff line numberDiff line change
@@ -227,3 +227,17 @@ test('mutation error is returned by talon', async () => {
227227
`[Error: Uh oh! There was an error signing in :(]`
228228
);
229229
});
230+
231+
it('should call handleForgotPassword when Enter key is pressed', () => {
232+
const { result } = renderHookWithProviders();
233+
const { forgotPasswordHandleEnterKeyPress } = result.current;
234+
const enterKeyEvent = { key: 'Enter' };
235+
renderHook(() => forgotPasswordHandleEnterKeyPress(enterKeyEvent));
236+
});
237+
238+
it('should call handleEnterKeyPress when Enter key is pressed', () => {
239+
const { result } = renderHookWithProviders();
240+
const { handleEnterKeyPress } = result.current;
241+
const enterKeyEvent = { key: 'Enter' };
242+
renderHook(() => handleEnterKeyPress(enterKeyEvent));
243+
});

packages/peregrine/lib/talons/SignIn/useSignIn.js

+13-9
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ export const useSignIn = props => {
6868
async ({ email, password }) => {
6969
setIsSigningIn(true);
7070
handleTriggerClick();
71+
7172
try {
7273
// Get source cart id (guest cart id).
7374
const sourceCartId = cartId;
@@ -159,13 +160,14 @@ export const useSignIn = props => {
159160
showForgotPassword();
160161
}, [setDefaultUsername, showForgotPassword]);
161162

162-
const forgotPasswordHandleEnterKeyPress = useCallback(() => {
163+
const forgotPasswordHandleEnterKeyPress = useCallback(
163164
event => {
164165
if (event.key === 'Enter') {
165166
handleForgotPassword();
166167
}
167-
};
168-
}, [handleForgotPassword]);
168+
},
169+
[handleForgotPassword]
170+
);
169171

170172
const handleCreateAccount = useCallback(() => {
171173
const { current: formApi } = formApiRef;
@@ -177,21 +179,23 @@ export const useSignIn = props => {
177179
showCreateAccount();
178180
}, [setDefaultUsername, showCreateAccount]);
179181

180-
const handleEnterKeyPress = useCallback(() => {
182+
const handleEnterKeyPress = useCallback(
181183
event => {
182184
if (event.key === 'Enter') {
183185
handleCreateAccount();
184186
}
185-
};
186-
}, [handleCreateAccount]);
187+
},
188+
[handleCreateAccount]
189+
);
187190

188-
const signinHandleEnterKeyPress = useCallback(() => {
191+
const signinHandleEnterKeyPress = useCallback(
189192
event => {
190193
if (event.key === 'Enter') {
191194
handleSubmit();
192195
}
193-
};
194-
}, [handleSubmit]);
196+
},
197+
[handleSubmit]
198+
);
195199

196200
const errors = useMemo(
197201
() =>

0 commit comments

Comments
 (0)