Skip to content

[feature]: Change the ProductDetail query from url_key to id #2835

Open
@lewisvoncken

Description

Describe the solution you'd like
You do a Product search based on url_key but the url_key is already resolved and returns the actual product id so you can just retrieve the data for that specific product and not query on the url_key. This is also better for performance.

see for more info https://github.com/magento/pwa-studio/blob/develop/packages/venia-ui/lib/RootComponents/Product/product.js#L26

When the url_key is not searchable and you use the url_key to get the info of the current product, all the product detail pages will be the same

Please let us know what packages this feature is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions