Skip to content

[bug]: fix <Select> to use Peregrine's "useInformedFieldStateWrapper" like other form inputs do #4381

Open
@brendanfalkowski

Description

Describe the bug

In 2021, this PR was created to suppress a noisy warning from the informed form library:
#3399

A new hook useInformedFieldStateWrapper was created which wraps Informed's useFieldState. Instances of useFieldState were modified to use the new hook:

  • Checkbox
  • RadioGroup
  • TextArea
  • TextInput
  • ...and a bunch of hooks (useQuantity, usePaymentMethods, usePostcode, useRegion, useSearchField, useAutocomplete)

See file changes: https://github.com/magento/pwa-studio/pull/3399/files

Not sure why, but Select form inputs in Venia UI were excluded from this change in that PR. There's no mention of why. It still uses useFieldState directly from Informed, which causes the same noisy warnings.

To reproduce

Observed in our custom application. I don't think this happens in the Venia demo.

Adding a <Select> input in our footer causes these console warnings on load.

Possible solutions

Fix it by using useInformedFieldStateWrapper in Select.

Please let us know what packages this bug is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions