Merge pull request #6 from magento-trigger/AC-2892-fix-return-type

AC-2892 fix return type

Author: xmav

library/Zend/Pdf/Action.php

@@ -326,6 +326,7 @@ public function dumpAction(Zend_Pdf_ElementFactory_Interface $factory, SplObject
      *
      * @return Zend_Pdf_Action
      */
+    #[\ReturnTypeWillChange]
     public function current()
     {
         return current($this->next);
@@ -336,6 +337,7 @@ public function current()
      *
      * @return integer
      */
+    #[\ReturnTypeWillChange]
     public function key()
     {
         return key($this->next);
@@ -344,6 +346,7 @@ public function key()
     /**
      * Go to next child
      */
+    #[\ReturnTypeWillChange]
     public function next()
     {
         return next($this->next);
@@ -352,6 +355,7 @@ public function next()
     /**
      * Rewind children
      */
+    #[\ReturnTypeWillChange]
     public function rewind()
     {
         return reset($this->next);
@@ -362,6 +366,7 @@ public function rewind()
      *
      * @return boolean
      */
+    #[\ReturnTypeWillChange]
     public function valid()
     {
         return current($this->next) !== false;
@@ -372,6 +377,7 @@ public function valid()
      *
      * @return Zend_Pdf_Action|null
      */
+    #[\ReturnTypeWillChange]
     public function getChildren()
     {
         return current($this->next);
@@ -382,6 +388,7 @@ public function getChildren()
      *
      * @return bool  whether container has any pages
      */
+    #[\ReturnTypeWillChange]
     public function hasChildren()
     {
         return count($this->next) > 0;
@@ -397,6 +404,7 @@ public function hasChildren()
      *
      * @return int
      */
+    #[\ReturnTypeWillChange]
     public function count()
     {
         return count($this->childOutlines);

library/Zend/Pdf/Element/Reference.php

@@ -82,14 +82,18 @@ class Zend_Pdf_Element_Reference extends Zend_Pdf_Element
     /**
      * Object constructor:
      *
-     * @param integer $objNum
-     * @param integer $genNum
+     * @param int $objNum
+     * @param int $genNum
      * @param Zend_Pdf_Element_Reference_Context $context
      * @param Zend_Pdf_ElementFactory $factory
      * @throws Zend_Pdf_Exception
      */
-    public function __construct($objNum, $genNum = 0, Zend_Pdf_Element_Reference_Context $context, Zend_Pdf_ElementFactory $factory)
-    {
+    public function __construct(
+        $objNum,
+        $genNum,
+        Zend_Pdf_Element_Reference_Context $context,
+        Zend_Pdf_ElementFactory $factory
+    ){
         if ( !(is_integer($objNum) && $objNum > 0) ) {
             #require_once 'Zend/Pdf/Exception.php';
             throw new Zend_Pdf_Exception('Object number must be positive integer');

library/Zend/Pdf/NameTree.php

@@ -85,68 +85,71 @@ public function __construct(Zend_Pdf_Element $rootDictionary)
         }
     }
 
+    #[\ReturnTypeWillChange]
     public function current()
     {
         return current($this->_items);
     }
 
-
+    #[\ReturnTypeWillChange]
     public function next()
     {
         return next($this->_items);
     }
 
-
+    #[\ReturnTypeWillChange]
     public function key()
     {
         return key($this->_items);
     }
 
-
-    public function valid() {
+    #[\ReturnTypeWillChange]
+    public function valid()
+    {
         return current($this->_items)!==false;
     }
 
-
+    #[\ReturnTypeWillChange]
     public function rewind()
     {
         reset($this->_items);
     }
 
-
+    #[\ReturnTypeWillChange]
     public function offsetExists($offset)
     {
         return array_key_exists($offset, $this->_items);
     }
 
-
+    #[\ReturnTypeWillChange]
     public function offsetGet($offset)
     {
         return $this->_items[$offset];
     }
 
-
+    #[\ReturnTypeWillChange]
     public function offsetSet($offset, $value)
     {
         if ($offset === null) {
-            $this->_items[]        = $value;
+            $this->_items[] = $value;
         } else {
             $this->_items[$offset] = $value;
         }
     }
 
-
+    #[\ReturnTypeWillChange]
     public function offsetUnset($offset)
     {
         unset($this->_items[$offset]);
     }
 
-
+    #[\ReturnTypeWillChange]
     public function clear()
     {
         $this->_items = array();
     }
 
+    #[\ReturnTypeWillChange]
     public function count()
     {
         return count($this->_items);

library/Zend/Pdf/Outline.php

@@ -295,6 +295,7 @@ abstract public function dumpOutline(Zend_Pdf_ElementFactory_Interface $factory,
      *
      * @return Zend_Pdf_Outline
      */
+    #[\ReturnTypeWillChange]
     public function current()
     {
         return current($this->childOutlines);
@@ -305,6 +306,7 @@ public function current()
      *
      * @return integer
      */
+    #[\ReturnTypeWillChange]
     public function key()
     {
         return key($this->childOutlines);
@@ -313,6 +315,7 @@ public function key()
     /**
      * Go to next child
      */
+    #[\ReturnTypeWillChange]
     public function next()
     {
         return next($this->childOutlines);
@@ -321,6 +324,7 @@ public function next()
     /**
      * Rewind children
      */
+    #[\ReturnTypeWillChange]
     public function rewind()
     {
         return reset($this->childOutlines);
@@ -331,6 +335,7 @@ public function rewind()
      *
      * @return boolean
      */
+    #[\ReturnTypeWillChange]
     public function valid()
     {
         return current($this->childOutlines) !== false;
@@ -341,6 +346,7 @@ public function valid()
      *
      * @return Zend_Pdf_Outline|null
      */
+    #[\ReturnTypeWillChange]
     public function getChildren()
     {
         return current($this->childOutlines);
@@ -351,6 +357,7 @@ public function getChildren()
      *
      * @return bool  whether container has any pages
      */
+    #[\ReturnTypeWillChange]
     public function hasChildren()
     {
         return count($this->childOutlines) > 0;
@@ -366,6 +373,7 @@ public function hasChildren()
      *
      * @return int
      */
+    #[\ReturnTypeWillChange]
     public function count()
     {
         return count($this->childOutlines);

library/Zend/Pdf/StringParser.php

@@ -514,7 +514,12 @@ private function _readReference($nextLexeme = null)
             return null;
         }
 
-        $ref = new Zend_Pdf_Element_Reference((int)$objNum, (int)$genNum, $this->_context, $this->_objFactory->resolve());
+        $ref = new Zend_Pdf_Element_Reference(
+            (int)$objNum,
+            (int)$genNum,
+            $this->_context,
+            $this->_objFactory->resolve()
+        );
 
         return $ref;
     }