Prevent out-of-bounds array access in TCommandSet

Fixes #216

Author: magiblot

include/tvision/views.h

@@ -238,7 +238,7 @@ class TCommandSet
 
 private:
 
-    int loc( int ) noexcept;
+    uint loc( int ) noexcept;
     int mask( int ) noexcept;
 
     static int _NEAR masks[8];
@@ -272,9 +272,9 @@ inline int operator != ( const TCommandSet& tc1, const TCommandSet& tc2 ) noexce
     return !operator == ( tc1, tc2 );
 }
 
-inline int TCommandSet::loc( int cmd ) noexcept
+inline uint TCommandSet::loc( int cmd ) noexcept
 {
-    return cmd / 8;
+    return (uint) cmd / 8;
 }
 
 inline int TCommandSet::mask( int cmd ) noexcept

source/tvision/tcmdset.cpp

@@ -47,12 +47,15 @@ TCommandSet& TCommandSet::operator = ( const TCommandSet& tc ) noexcept
 
 Boolean TCommandSet::has( int cmd ) noexcept
 {
-    return Boolean( (cmds[ loc( cmd ) ] & mask( cmd )) != 0 );
+    if( loc( cmd ) < 32 )
+        return Boolean( (cmds[ loc( cmd ) ] & mask( cmd )) != 0 );
+    return False;
 }
 
 void TCommandSet::disableCmd( int cmd ) noexcept
 {
-    cmds[ loc( cmd ) ] &= ~mask( cmd );
+    if( loc( cmd ) < 32 )
+        cmds[ loc( cmd ) ] &= ~mask( cmd );
 }
 
 void TCommandSet::enableCmd( const TCommandSet& tc ) noexcept
@@ -69,7 +72,8 @@ void TCommandSet::disableCmd( const TCommandSet& tc ) noexcept
 
 void TCommandSet::enableCmd( int cmd ) noexcept
 {
-    cmds[ loc( cmd ) ] |= mask( cmd );
+    if( loc( cmd ) < 32 )
+        cmds[ loc( cmd ) ] |= mask( cmd );
 }
 
 TCommandSet& TCommandSet::operator &= ( const TCommandSet& tc ) noexcept