fix(security): 2 improvements across 2 files

tomaioo · tomaioo · commit 241383804421 · 2026-06-16T17:14:45.000-07:00
- Security: Arbitrary Code Execution via eval() in Menu Model
- Security: Arbitrary Code Execution via eval() in GroupModule Model

Signed-off-by: tomaioo &lt;203048277+tomaioo@users.noreply.github.com&gt;
diff --git a/app/model/GroupModule.js b/app/model/GroupModule.js
@@ -17,7 +17,7 @@ Ext.define('MBilling.model.GroupModule', {
         name: 'idModuletext',
         type: 'string',
         convert: function(value) {
-            return eval(value);
+            return value;
         }
     }, {
         name: 'show_menu',

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ Ext.define('MBilling.model.GroupModule', {`
`17`	`17`	`name: 'idModuletext',`
`18`	`18`	`type: 'string',`
`19`	`19`	`convert: function(value) {`
`20`		`- return eval(value);`
	`20`	`+ return value;`
`21`	`21`	`}`
`22`	`22`	`}, {`
`23`	`23`	`name: 'show_menu',`