chore(typescript): utils/serialize-cookie

Author: BobrImperator

packages/ember-cookies/src/services/cookies.js

@@ -3,7 +3,7 @@ import { get } from '@ember/object';
 import { assert } from '@ember/debug';
 import { getOwner } from '@ember/application';
 import Service from '@ember/service';
-import { serializeCookie } from '../utils/serialize-cookie';
+import { serializeCookie } from '../utils/serialize-cookie.ts';
 const { keys } = Object;
 const DEFAULTS = { raw: false };
 const MAX_COOKIE_BYTE_LENGTH = 4096;

packages/ember-cookies/src/test-support/clear-all-cookies.js

@@ -1,6 +1,6 @@
 import { assert } from '@ember/debug';
 import { isEmpty } from '@ember/utils';
-import { serializeCookie } from '../utils/serialize-cookie';
+import { serializeCookie } from '../utils/serialize-cookie.ts';
 
 export default function clearAllCookies(options = {}) {
   assert('Cookies cannot be set to be HTTP-only from a browser!', !options.httpOnly);

packages/ember-cookies/src/utils/serialize-cookie.js renamed to packages/ember-cookies/src/utils/serialize-cookie.ts

@@ -1,12 +1,23 @@
 import { typeOf, isEmpty } from '@ember/utils';
 
-export const serializeCookie = (name, value, options = {}) => {
+interface Options {
+  maxAge?: number | string;
+  domain?: string;
+  expires?: Date;
+  secure?: boolean;
+  httpOnly?: boolean;
+  path?: string;
+  sameSite?: string;
+  partitioned?: boolean;
+}
+
+export const serializeCookie = (name: string, value: string, options: Options = {}) => {
   let cookie = `${name}=${value}`;
 
   if (!isEmpty(options.domain)) {
     cookie = `${cookie}; domain=${options.domain}`;
   }
-  if (typeOf(options.expires) === 'date') {
+  if (options.expires && typeOf(options.expires) === 'date') {
     cookie = `${cookie}; expires=${options.expires.toUTCString()}`;
   }
   if (!isEmpty(options.maxAge)) {

packages/ember-cookies/unpublished-development-types/index.d.ts

@@ -0,0 +1 @@
+import '@types/ember__utils';

packages/test-app/package.json

@@ -89,4 +89,4 @@
   "ember": {
     "edition": "octane"
   }
-}
+}