notification task code refactor + copy changes for UI

Author: Saurabhkmr98

apiserver/plane/bgtasks/notification_task.py

@@ -157,37 +157,45 @@ export const TASK_UPDATES_NOTIFICATION_SETTINGS: TNotificationSettings[] = [
   {
     key: ENotificationSettingsKey.PROPERTY_CHANGE,
     i18n_title: "notification_settings.work_item_property_title",
+    i18n_subtitle: "notification_settings.work_item_property_subtitle",
   },
   {
     key: ENotificationSettingsKey.STATE_CHANGE,
     i18n_title: "notification_settings.status_title",
+    i18n_subtitle: "notification_settings.status_subtitle",
   },
   {
     key: ENotificationSettingsKey.PRIORITY,
     i18n_title: "notification_settings.priority_title",
+    i18n_subtitle: "notification_settings.priority_subtitle",
   },
   {
     key: ENotificationSettingsKey.ASSIGNEE,
     i18n_title: "notification_settings.assignee_title",
+    i18n_subtitle: "notification_settings.assignee_subtitle",
   },
   {
     key: ENotificationSettingsKey.START_DUE_DATE,
     i18n_title: "notification_settings.due_date_title",
+    i18n_subtitle: "notification_settings.due_date_subtitle",
   }
 ]
 
 export const COMMENT_NOTIFICATION_SETTINGS: TNotificationSettings[] = [
   {
     key: ENotificationSettingsKey.MENTIONED_COMMENTS,
     i18n_title: "notification_settings.mentioned_comments_title",
+    i18n_subtitle: "notification_settings.mentioned_comments_subtitle",
   },
   {
     key: ENotificationSettingsKey.COMMENTS,
     i18n_title: "notification_settings.new_comments_title",
+    i18n_subtitle: "notification_settings.new_comments_subtitle",
   },
   {
     key: ENotificationSettingsKey.COMMENT_REACTIONS,
     i18n_title: "notification_settings.reaction_comments_title",
+    i18n_subtitle: "notification_settings.reaction_comments_subtitle",
   },
 ]
 

packages/constants/src/notification.ts

@@ -2183,23 +2183,33 @@
   "notification_settings": {
     "page_label": "{workspace} - Inbox settings",
     "inbox_settings": "Inbox settings",
-    "inbox_settings_description": "Toggle these ON or OFF for the workspace",
+    "inbox_settings_description": "Customize how you receive notifications for activities in your workspace. Your changes are saved automatically.",
     "advanced_settings": "Advanced settings",
     "in_plane": "In Plane",
     "email": "Email",
     "slack": "Slack",
-    "task_updates": "Task updates",
+    "task_updates": "Work item updates",
+    "task_updates_subtitle": "Get notified when work items in your workspace are updated.",
     "comments": "Comments",
-    "work_item_property_title": "Update on any property of work item",
-    "status_title": "State update",
-    "priority_title": "Priority update",
-    "assignee_title": "Assignee update",
-    "due_date_title": "Start/Due date update",
+    "comments_subtitle": "Stay updated on discussions in your workspace.",
+    "work_item_property_title": "Update on any property of the work item",
+    "work_item_property_subtitle": "Get notified when work items in your workspace are updated.",
+    "status_title": "State change",
+    "status_subtitle": "When a work item's state is updated.",
+    "priority_title": "Priority change",
+    "priority_subtitle": "When a work item's priority level is adjusted.",
+    "assignee_title": "Assignee change",
+    "assignee_subtitle": "When a work item is assigned or reassigned to someone.",
+    "due_date_title": "Date change",
+    "due_date_subtitle": "When a work item's start or due date is updated.",
     "module_title": "Module update",
     "cycle_title": "Cycle update",
-    "mentioned_comments_title": "Comments I'm @mentioned in",
+    "mentioned_comments_title": "Mentions",
+    "mentioned_comments_subtitle": "When someone mentions you in a comment.",
     "new_comments_title": "New comments",
+    "new_comments_subtitle": "When a new comment is added to a task you’re following.",
     "reaction_comments_title": "Reactions",
+    "reaction_comments_subtitle": "Get notified when someone reacts to your comments or tasks with an emoji.",
     "setting_updated_successfully": "Setting updated successfully",
     "failed_to_update_setting": "Failed to update setting"
   }

packages/i18n/src/locales/en/translations.json

@@ -2350,26 +2350,36 @@
   },
 
   "notification_settings": {
-    "page_label": "{workspace} - Configuración de la bandeja de entrada",
-    "inbox_settings": "Configuración de la bandeja de entrada",
-    "inbox_settings_description": "Activa o desactiva estas opciones para el espacio de trabajo",
+    "page_label": "{workspace} - Configuración de bandeja de entrada",
+    "inbox_settings": "Configuración de bandeja de entrada",
+    "inbox_settings_description": "Personaliza cómo recibes notificaciones para actividades en tu espacio de trabajo. Tus cambios se guardan automáticamente.",
     "advanced_settings": "Configuración avanzada",
     "in_plane": "En Plane",
     "email": "Correo electrónico",
     "slack": "Slack",
-    "task_updates": "Actualizaciones de tareas",
+    "task_updates": "Actualizaciones de elementos de trabajo",
+    "task_updates_subtitle": "Recibe notificaciones cuando se actualicen elementos de trabajo en tu espacio de trabajo.",
     "comments": "Comentarios",
+    "comments_subtitle": "Mantente actualizado sobre las discusiones en tu espacio de trabajo.",
     "work_item_property_title": "Actualización de cualquier propiedad del elemento de trabajo",
-    "status_title": "Actualización de estado",
-    "priority_title": "Actualización de prioridad",
-    "assignee_title": "Actualización de asignado",
-    "due_date_title": "Actualización de fecha de inicio/vencimiento",
+    "work_item_property_subtitle": "Recibe notificaciones cuando se actualicen elementos de trabajo en tu espacio de trabajo.",
+    "status_title": "Cambio de estado",
+    "status_subtitle": "Cuando se actualiza el estado de un elemento de trabajo.",
+    "priority_title": "Cambio de prioridad",
+    "priority_subtitle": "Cuando se ajusta el nivel de prioridad de un elemento de trabajo.",
+    "assignee_title": "Cambio de asignación",
+    "assignee_subtitle": "Cuando un elemento de trabajo es asignado o reasignado a alguien.",
+    "due_date_title": "Cambio de fecha",
+    "due_date_subtitle": "Cuando se actualiza la fecha de inicio o vencimiento de un elemento de trabajo.",
     "module_title": "Actualización de módulo",
     "cycle_title": "Actualización de ciclo",
-    "mentioned_comments_title": "Comentarios en los que estoy @mencionado",
+    "mentioned_comments_title": "Menciones",
+    "mentioned_comments_subtitle": "Cuando alguien te menciona en un comentario.",
     "new_comments_title": "Nuevos comentarios",
+    "new_comments_subtitle": "Cuando se agrega un nuevo comentario a una tarea que sigues.",
     "reaction_comments_title": "Reacciones",
-    "setting_updated_successfully": "Configuración actualizada correctamente",
-    "failed_to_update_setting": "No se pudo actualizar la configuración"
+    "reaction_comments_subtitle": "Recibe notificaciones cuando alguien reacciona a tus comentarios o tareas con un emoji.",
+    "setting_updated_successfully": "Configuración actualizada con éxito",
+    "failed_to_update_setting": "Error al actualizar la configuración"
   }
 }

packages/i18n/src/locales/es/translations.json

@@ -2350,25 +2350,35 @@
   },
 
   "notification_settings": {
-    "page_label": "{workspace} - Paramètres de la boîte de réception",
-    "inbox_settings": "Paramètres de la boîte de réception",
-    "inbox_settings_description": "Activez ou désactivez ces options pour l'espace de travail",
+    "page_label": "{workspace} - Paramètres de boîte de réception",
+    "inbox_settings": "Paramètres de boîte de réception",
+    "inbox_settings_description": "Personnalisez la façon dont vous recevez des notifications pour les activités dans votre espace de travail. Vos modifications sont enregistrées automatiquement.",
     "advanced_settings": "Paramètres avancés",
     "in_plane": "Dans Plane",
     "email": "E-mail",
     "slack": "Slack",
-    "task_updates": "Mises à jour des tâches",
+    "task_updates": "Mises à jour des éléments de travail",
+    "task_updates_subtitle": "Soyez notifié lorsque des éléments de travail dans votre espace de travail sont mis à jour.",
     "comments": "Commentaires",
-    "work_item_property_title": "Mise à jour de toute propriété de l'élément de travail",
-    "status_title": "Mise à jour de l'état",
-    "priority_title": "Mise à jour de la priorité",
-    "assignee_title": "Mise à jour de l'assigné",
-    "due_date_title": "Mise à jour de la date de début/d'échéance",
-    "module_title": "Mise à jour du module",
-    "cycle_title": "Mise à jour du cycle",
-    "mentioned_comments_title": "Commentaires où je suis @mentionné",
+    "comments_subtitle": "Restez informé des discussions dans votre espace de travail.",
+    "work_item_property_title": "Mise à jour de n'importe quelle propriété de l'élément de travail",
+    "work_item_property_subtitle": "Soyez notifié lorsque des éléments de travail dans votre espace de travail sont mis à jour.",
+    "status_title": "Changement d'état",
+    "status_subtitle": "Lorsque l'état d'un élément de travail est mis à jour.",
+    "priority_title": "Changement de priorité",
+    "priority_subtitle": "Lorsque le niveau de priorité d'un élément de travail est ajusté.",
+    "assignee_title": "Changement d'assignation",
+    "assignee_subtitle": "Lorsqu'un élément de travail est assigné ou réassigné à quelqu'un.",
+    "due_date_title": "Changement de date",
+    "due_date_subtitle": "Lorsque la date de début ou d'échéance d'un élément de travail est mise à jour.",
+    "module_title": "Mise à jour de module",
+    "cycle_title": "Mise à jour de cycle",
+    "mentioned_comments_title": "Mentions",
+    "mentioned_comments_subtitle": "Lorsque quelqu'un vous mentionne dans un commentaire.",
     "new_comments_title": "Nouveaux commentaires",
+    "new_comments_subtitle": "Lorsqu'un nouveau commentaire est ajouté à une tâche que vous suivez.",
     "reaction_comments_title": "Réactions",
+    "reaction_comments_subtitle": "Soyez notifié lorsque quelqu'un réagit à vos commentaires ou tâches avec un emoji.",
     "setting_updated_successfully": "Paramètre mis à jour avec succès",
     "failed_to_update_setting": "Échec de la mise à jour du paramètre"
   }

packages/i18n/src/locales/fr/translations.json

@@ -2352,23 +2352,33 @@
   "notification_settings": {
     "page_label": "{workspace} - 受信トレイ設定",
     "inbox_settings": "受信トレイ設定",
-    "inbox_settings_description": "ワークスペースのためにこれらをオンまたはオフに切り替えます",
+    "inbox_settings_description": "ワークスペースでのアクティビティに関する通知の受信方法をカスタマイズします。変更は自動的に保存されます。",
     "advanced_settings": "詳細設定",
     "in_plane": "Plane内",
     "email": "メール",
     "slack": "Slack",
-    "task_updates": "タスクの更新",
+    "task_updates": "作業項目の更新",
+    "task_updates_subtitle": "ワークスペース内の作業項目が更新されたときに通知を受け取ります。",
     "comments": "コメント",
-    "work_item_property_title": "作業項目のプロパティの更新",
-    "status_title": "状態の更新",
-    "priority_title": "優先度の更新",
-    "assignee_title": "担当者の更新",
-    "due_date_title": "開始日/期日の更新",
-    "module_title": "モジュールの更新",
-    "cycle_title": "サイクルの更新",
-    "mentioned_comments_title": "自分が@メンションされたコメント",
+    "comments_subtitle": "ワークスペース内のディスカッションに関する最新情報を入手します。",
+    "work_item_property_title": "作業項目のあらゆるプロパティの更新",
+    "work_item_property_subtitle": "ワークスペース内の作業項目が更新されたときに通知を受け取ります。",
+    "status_title": "状態変更",
+    "status_subtitle": "作業項目の状態が更新されたとき。",
+    "priority_title": "優先度変更",
+    "priority_subtitle": "作業項目の優先度レベルが調整されたとき。",
+    "assignee_title": "担当者変更",
+    "assignee_subtitle": "作業項目が誰かに割り当てられたり再割り当てされたとき。",
+    "due_date_title": "日付変更",
+    "due_date_subtitle": "作業項目の開始日または期日が更新されたとき。",
+    "module_title": "モジュール更新",
+    "cycle_title": "サイクル更新",
+    "mentioned_comments_title": "メンション",
+    "mentioned_comments_subtitle": "誰かがコメントであなたに言及したとき。",
     "new_comments_title": "新しいコメント",
+    "new_comments_subtitle": "フォローしているタスクに新しいコメントが追加されたとき。",
     "reaction_comments_title": "リアクション",
+    "reaction_comments_subtitle": "誰かがあなたのコメントやタスクに絵文字でリアクションしたときに通知を受け取ります。",
     "setting_updated_successfully": "設定が正常に更新されました",
     "failed_to_update_setting": "設定の更新に失敗しました"
   }

packages/i18n/src/locales/ja/translations.json

@@ -2352,24 +2352,34 @@
   "notification_settings": {
     "page_label": "{workspace} - 收件箱设置",
     "inbox_settings": "收件箱设置",
-    "inbox_settings_description": "为工作空间打开或关闭这些选项",
+    "inbox_settings_description": "自定义如何接收工作空间活动的通知。您的更改会自动保存。",
     "advanced_settings": "高级设置",
-    "in_plane": "在 Plane",
+    "in_plane": "在Plane中",
     "email": "电子邮件",
     "slack": "Slack",
-    "task_updates": "任务更新",
+    "task_updates": "工作项更新",
+    "task_updates_subtitle": "当您工作空间中的工作项被更新时获得通知。",
     "comments": "评论",
-    "work_item_property_title": "工作项属性更新",
-    "status_title": "状态更新",
-    "priority_title": "优先级更新",
-    "assignee_title": "负责人更新",
-    "due_date_title": "开始/截止日期更新",
+    "comments_subtitle": "随时了解您工作空间中的讨论。",
+    "work_item_property_title": "工作项任何属性的更新",
+    "work_item_property_subtitle": "当您工作空间中的工作项被更新时获得通知。",
+    "status_title": "状态变更",
+    "status_subtitle": "当工作项的状态被更新时。",
+    "priority_title": "优先级变更",
+    "priority_subtitle": "当工作项的优先级被调整时。",
+    "assignee_title": "负责人变更",
+    "assignee_subtitle": "当工作项被分配或重新分配给某人时。",
+    "due_date_title": "日期变更",
+    "due_date_subtitle": "当工作项的开始日期或截止日期被更新时。",
     "module_title": "模块更新",
     "cycle_title": "周期更新",
-    "mentioned_comments_title": "我被@提及的评论",
+    "mentioned_comments_title": "提及",
+    "mentioned_comments_subtitle": "当有人在评论中提及您时。",
     "new_comments_title": "新评论",
+    "new_comments_subtitle": "当您关注的任务添加了新评论时。",
     "reaction_comments_title": "反应",
-    "setting_updated_successfully": "设置已成功更新",
+    "reaction_comments_subtitle": "当有人用表情符号对您的评论或任务做出反应时获得通知。",
+    "setting_updated_successfully": "设置更新成功",
     "failed_to_update_setting": "设置更新失败"
   }
 }

packages/i18n/src/locales/zh-CN/translations.json

@@ -2,6 +2,7 @@ import { ENotificationSettingsKey, EWorkspaceNotificationTransport } from "@plan
 
 export type TNotificationSettings = {
     i18n_title: string,
+    i18n_subtitle?: string,
     key: ENotificationSettingsKey
 }
 

packages/types/src/notification.d.ts

@@ -12,8 +12,13 @@ export const InboxSettingsRoot: FC = () => {
   return (
     <>
       <div className="flex flex-col gap-5 pt-4 pb-10 border-b border-custom-border-100">
-        <div className="text-lg font-normal text-custom-text-100">
-          {t("notification_settings.task_updates")}
+        <div className="flex flex-col gap-1">
+          <div className="text-lg font-normal text-custom-text-100">
+            {t("notification_settings.task_updates")}
+          </div>
+          <div className="text-sm text-custom-text-350">
+            {t("notification_settings.task_updates_subtitle")}
+          </div>
         </div>
         <div className="grid gap-4 grid-cols-[50%_repeat(auto-fit,minmax(0,1fr))] text-sm text-custom-text-350 font-semibold">
           <div>{t("notification_settings.advanced_settings")}</div>
@@ -22,13 +27,18 @@ export const InboxSettingsRoot: FC = () => {
         </div>
         {
           TASK_UPDATES_NOTIFICATION_SETTINGS?.map((item) => (
-            <InboxSettingUpdateRow key={item.key} settings_key={item.key} title={item.i18n_title} />
+            <InboxSettingUpdateRow key={item.key} settings_key={item.key} title={item.i18n_title} subtitle={item.i18n_subtitle} />
           ))
         }
       </div>
       <div className="flex flex-col gap-5 py-4">
-        <div className="text-lg font-normal text-custom-text-100">
-          {t("notification_settings.comments")}
+        <div className="flex flex-col gap-1">
+          <div className="text-lg font-normal text-custom-text-100">
+            {t("notification_settings.comments")}
+          </div>
+          <div className="text-sm text-custom-text-350">
+            {t("notification_settings.comments_subtitle")}
+          </div>
         </div>
         <div className="grid gap-4 grid-cols-[50%_repeat(auto-fit,minmax(0,1fr))] text-sm text-custom-text-350 font-semibold">
           <div>{t("notification_settings.advanced_settings")}</div>
@@ -37,7 +47,7 @@ export const InboxSettingsRoot: FC = () => {
         </div>
         {
           COMMENT_NOTIFICATION_SETTINGS?.map((item, index) => (
-            <InboxSettingUpdateRow key={index} settings_key={item.key} title={item.i18n_title} />
+            <InboxSettingUpdateRow key={index} settings_key={item.key} title={item.i18n_title} subtitle={item.i18n_subtitle} />
           ))
         }
       </div>

web/core/components/inbox/settings/root.tsx

@@ -9,17 +9,25 @@ import { InboxSettingUpdate } from "./update-setting";
 type InboxSettingUpdateRowProps = {
     settings_key: ENotificationSettingsKey;
     title: string;
+    subtitle?: string
 }
 
 export const InboxSettingUpdateRow: FC<InboxSettingUpdateRowProps> = observer((props: InboxSettingUpdateRowProps) => {
-    const { title, settings_key } = props;
+    const { title, subtitle, settings_key } = props;
 
     const { t } = useTranslation()
 
     return (
         <div className="w-full grid gap-4 grid-cols-[50%_repeat(auto-fit,minmax(0,1fr))]">
-            <div className="text-base font-normal text-custom-text-200">
-                {t(title)}
+            <div className="flex flex-col gap-1">
+                <div className="text-base font-normal text-custom-text-200">
+                    {t(title)}
+                </div>
+                {
+                    subtitle && <div className="text-sm text-custom-text-350">
+                        {t(subtitle)}
+                    </div>
+                }
             </div>
             <div className="">
                 <InboxSettingUpdate transport={EWorkspaceNotificationTransport.IN_APP} settings_key={settings_key} />