-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Open
Labels
Description
Is there an existing issue for this?
- I have searched the existing issues
Current behavior
No matter what is set in the CORS_ALLOWED_ORIGINS variable, it seems that the application host is always used as the value. I tried setting "*" and got an appropriate error. I tried "" but the response header still hat the application host in it. I also tried a list with the two domains I need but still got only the application fqdn back.
I found the issue while figuring out another CORS issue which was related to missing CORS config on my S3 backend.
Steps to reproduce
- Set CORS_ALLOWED_ORIGINS to empty string or mutliple domains
- Try to upload an avatar
- Watch browser request to
https://<my-plane-instance>/api/assets/v2/user-assets/withaccess-control-allow-origin: https://<my-plane-instance>/with the other URI missing
Environment
Production
Browser
Google Chrome
Variant
Self-hosted
Version
v1.2.1