General Facebook Blob Fixes

Had a couple bugs.

PL-25385

Author: Allen Tsai

src/PaperG/FirehoundBlob/Facebook/AdSets/GeneralFacebookAdSet.php

@@ -39,7 +39,7 @@ public function getBudget()
     }
 
     /**
-     * @return null|FacebookCreative
+     * @return null|FacebookCreative[]
      */
     public function getCreatives()
     {

src/PaperG/FirehoundBlob/Scenario.php

@@ -19,5 +19,13 @@ class Scenario
     const AN_DESKTOP_MOBILE = 'AppNexus-Desktop-Mobile';
     const DCM_UNMANAGED = "DCM-Unmanaged";
 
-    public static $validScenarios = [self::FB_MANAGED, self::FB_UNMANAGED, self::AN_DESKTOP, self::AN_MOBILE, self::AN_DESKTOP_MOBILE, self::DCM_UNMANAGED];
+    public static $validScenarios = [
+        self::FB_MANAGED,
+        self::FB_UNMANAGED,
+        self::FB_UNMANAGED_V2,
+        self::AN_DESKTOP,
+        self::AN_MOBILE,
+        self::AN_DESKTOP_MOBILE,
+        self::DCM_UNMANAGED
+    ];
 }

src/PaperG/FirehoundBlob/ScenarioBlob.php

@@ -4,7 +4,7 @@
 
 use PaperG\FirehoundBlob\AppNexus\AppNexusBlob;
 use PaperG\FirehoundBlob\Dcm\UnmanagedDcmBlob;
-use PaperG\FirehoundBlob\Facebook\ManagedFacebookBlob;
+use PaperG\FirehoundBlob\Facebook\GeneralFacebookBlob;
 use PaperG\FirehoundBlob\Facebook\UnmanagedFacebookBlob;
 
 class ScenarioBlob implements BlobInterface
@@ -72,8 +72,9 @@ public function fromArray($array)
             case Scenario::FB_UNMANAGED:
                 $this->blob = new UnmanagedFacebookBlob($blobArray);
                 break;
+            case Scenario::FB_UNMANAGED_V2:
             case Scenario::FB_MANAGED:
-                $this->blob = new ManagedFacebookBlob($blobArray);
+                $this->blob = new GeneralFacebookBlob($blobArray);
                 break;
             case Scenario::DCM_UNMANAGED:
                 $this->blob = new UnmanagedDcmBlob($blobArray);

test/phpunit/src/PaperG/FirehoundBlob/ScenarioBlobTest.php

@@ -6,6 +6,12 @@
 use PaperG\FirehoundBlob\AppNexus\Fields\AppNexusBlobFields;
 use PaperG\FirehoundBlob\BasicInfo;
 use PaperG\FirehoundBlob\Dcm\UnmanagedDcmBlob;
+use PaperG\FirehoundBlob\Facebook\FacebookAdSet;
+use PaperG\FirehoundBlob\Facebook\FacebookCreative;
+use PaperG\FirehoundBlob\Facebook\Fields\GeneralFacebookAdSetFields;
+use PaperG\FirehoundBlob\Facebook\Fields\GeneralFacebookBlobFields;
+use PaperG\FirehoundBlob\Facebook\GeneralFacebookBlob;
+use PaperG\FirehoundBlob\Facebook\UnmanagedFacebookBlob;
 use PaperG\FirehoundBlob\Scenario;
 use PaperG\FirehoundBlob\ScenarioBlob;
 
@@ -67,4 +73,77 @@ public function testFromArrayDcm()
         $blob = $sut->getBlob();
         $this->assertEquals($mockAdvId, $blob->getAdvertiserId());
     }
+
+    public function testFromArrayUnmanagedFacebook()
+    {
+        $mockAdSetId = 'mock ad set id';
+        $array = [
+            ScenarioBlob::BASIC_INFO => [BasicInfo::SCENARIO => Scenario::FB_UNMANAGED],
+            ScenarioBlob::BLOB => [
+                GeneralFacebookBlobFields::AD_SETS => [
+                    [
+                        FacebookAdSet::AD_SET_ID => $mockAdSetId
+                    ]
+                ]
+            ]
+        ];
+        $sut = new ScenarioBlob($array);
+        /**
+         * @var UnmanagedFacebookBlob $blob
+         */
+        $blob = $sut->getBlob();
+        $this->assertEquals($mockAdSetId, $blob->getAdSets()[0]->getAdSetId());
+    }
+
+    public function testFromArrayManagedFacebook()
+    {
+        $mockAdSetId = 'mock ad set id';
+        $mockType = 'mock facebook creative type';
+        $array = [
+            ScenarioBlob::BASIC_INFO => [BasicInfo::SCENARIO => Scenario::FB_MANAGED],
+            ScenarioBlob::BLOB => [
+                GeneralFacebookBlobFields::AD_SETS => [
+                    [
+                        GeneralFacebookAdSetFields::AD_SET_ID => $mockAdSetId,
+                        GeneralFacebookAdSetFields::CREATIVES => [
+                            [FacebookCreative::TYPE => $mockType]
+                        ]
+                    ]
+                ]
+            ]
+        ];
+        $sut = new ScenarioBlob($array);
+        /**
+         * @var GeneralFacebookBlob $blob
+         */
+        $blob = $sut->getBlob();
+        $this->assertEquals($mockAdSetId, $blob->getAdSets()[0]->getAdSetId());
+        $this->assertEquals($mockType, $blob->getAdSets()[0]->getCreatives()[0]->getType());
+    }
+
+    public function testFromArrayUnmanagedFacebookV2()
+    {
+        $mockAdSetId = 'mock ad set id';
+        $mockType = 'mock facebook creative type';
+        $array = [
+            ScenarioBlob::BASIC_INFO => [BasicInfo::SCENARIO => Scenario::FB_UNMANAGED_V2],
+            ScenarioBlob::BLOB => [
+                GeneralFacebookBlobFields::AD_SETS => [
+                    [
+                        GeneralFacebookAdSetFields::AD_SET_ID => $mockAdSetId,
+                        GeneralFacebookAdSetFields::CREATIVES => [
+                            [FacebookCreative::TYPE => $mockType]
+                        ]
+                    ]
+                ]
+            ]
+        ];
+        $sut = new ScenarioBlob($array);
+        /**
+         * @var GeneralFacebookBlob $blob
+         */
+        $blob = $sut->getBlob();
+        $this->assertEquals($mockAdSetId, $blob->getAdSets()[0]->getAdSetId());
+        $this->assertEquals($mockType, $blob->getAdSets()[0]->getCreatives()[0]->getType());
+    }
 }