fatal error: sync: Unlock of unlocked RWMutex

[OfekShochat]

hello!
Ive looked at gemini quite some time ago, and looking back at it, its gotten really cool. though when I tried to open amfora after installing it in arch (tried both the amfora-git and amfora packages) I got this traceback:

atal error: sync: Unlock of unlocked RWMutex

goroutine 1 [running]:
runtime.throw({0xba92b1?, 0x5553dd?})
	/usr/lib/go/src/runtime/panic.go:992 +0x71 fp=0xc000207d80 sp=0xc000207d50 pc=0x432f31
sync.throw({0xba92b1?, 0x5693ba?})
	/usr/lib/go/src/runtime/panic.go:978 +0x1e fp=0xc000207da0 sp=0xc000207d80 pc=0x45dd3e
sync.(*RWMutex).Unlock(0xc00032500c)
	/usr/lib/go/src/sync/rwmutex.go:201 +0x4a fp=0xc000207dd8 sp=0xc000207da0 pc=0x47746a
code.rocketnine.space/tslocum/cview.(*Application).Init.func1()
	/home/ghostway/go/pkg/mod/code.rocketnine.space/tslocum/cview@v1.5.6-0.20210530175404-7e8817f20bdc/application.go:225 +0x26 fp=0xc000207df0 sp=0xc000207dd8 pc=0x569286
code.rocketnine.space/tslocum/cview.(*Application).Init(0xc000324f00)
	/home/ghostway/go/pkg/mod/code.rocketnine.space/tslocum/cview@v1.5.6-0.20210530175404-7e8817f20bdc/application.go:226 +0x98 fp=0xc000207e40 sp=0xc000207df0 pc=0x569218
main.main()
	/home/ghostway/.cache/paru/clone/amfora-git/src/amfora/amfora.go:76 +0x594 fp=0xc000207f80 sp=0xc000207e40 pc=0xa72594
runtime.main()
	/usr/lib/go/src/runtime/proc.go:250 +0x212 fp=0xc000207fe0 sp=0xc000207f80 pc=0x435652
runtime.goexit()
	/usr/lib/go/src/runtime/asm_amd64.s:1571 +0x1 fp=0xc000207fe8 sp=0xc000207fe0 pc=0x462401

goroutine 18 [sleep]:
time.Sleep(0x1a3185c5000)
	/usr/lib/go/src/runtime/time.go:194 +0x12e
github.com/makeworld-the-better-one/amfora/subscriptions.Init.func1()
	/home/ghostway/.cache/paru/clone/amfora-git/src/amfora/subscriptions/subscriptions.go:79 +0x3d
created by github.com/makeworld-the-better-one/amfora/subscriptions.Init
	/home/ghostway/.cache/paru/clone/amfora-git/src/amfora/subscriptions/subscriptions.go:76 +0x2a5

the same thing is happening when compiling from source.
thanks aot

[makew0rld]

Thanks for reporting, this is a strange bug and I can't reproduce it. Never seen it before. Can you show the output of amfora -v so I can see what version you're running?

[OfekShochat]

Amfora v1.9.2-27-gea9c7f2
Commit: ea9c7f214a06138e064992fdf6f7a1cdddb522f7
Built by: Makefile

It's the latest one

[OfekShochat]

@makeworld-the-better-one hey...

[alexsavage]

Same on freebsd 13.0 on arm64, using either the v1.9.2 pkg binary or building from source myself.

% uname -a
FreeBSD pebbles 13.0-RELEASE-p6 FreeBSD 13.0-RELEASE-p6 #0: Mon Jan 10 06:33:27 UTC 2022     root@arm64-builder.daemonology.net:/usr/obj/usr/src/arm64.aarch64/sys/GENERIC  arm64
% amfora -v
Amfora v1.9.2
Commit: 61d8645
Built by: unknown
% amfora
fatal error: sync: Unlock of unlocked RWMutex

goroutine 1 [running]:
runtime.throw({0x4ad6ab, 0x20})
        runtime/panic.go:1198 +0x54 fp=0x40001cdd60 sp=0x40001cdd30 pc=0x45fe4
sync.throw({0x4ad6ab, 0x20})
        runtime/panic.go:1184 +0x30 fp=0x40001cdd80 sp=0x40001cdd60 pc=0x73650
sync.(*RWMutex).Unlock(0x400022688c)
        sync/rwmutex.go:142 +0x88 fp=0x40001cddc0 sp=0x40001cdd80 pc=0x8c6f8
code.rocketnine.space/tslocum/cview.(*Application).Init(0x4000226780)
        code.rocketnine.space/tslocum/cview@v1.5.6-0.20210530175404-7e8817f20bdc/application.go:226 +0x8c fp=0x40001cde10 sp=0x40001cddc0 pc=0x179e1c
main.main()
        github.com/makeworld-the-better-one/amfora/amfora.go:71 +0x6ac fp=0x40001cdf70 sp=0x40001cde10 pc=0x3d4ccc
runtime.main()
        runtime/proc.go:255 +0x284 fp=0x40001cdfd0 sp=0x40001cdf70 pc=0x48884
runtime.goexit()
        runtime/asm_arm64.s:1133 +0x4 fp=0x40001cdfd0 sp=0x40001cdfd0 pc=0x77b94

goroutine 6 [runnable]:
github.com/makeworld-the-better-one/amfora/subscriptions.(*jsonData).RUnlock(0x893780)
        github.com/makeworld-the-better-one/amfora/subscriptions/structs.go:62 +0xdc
github.com/makeworld-the-better-one/amfora/subscriptions.updateAll()
        github.com/makeworld-the-better-one/amfora/subscriptions/subscriptions.go:393 +0x108
github.com/makeworld-the-better-one/amfora/subscriptions.Init.func1()
        github.com/makeworld-the-better-one/amfora/subscriptions/subscriptions.go:78 +0x20
created by github.com/makeworld-the-better-one/amfora/subscriptions.Init
        github.com/makeworld-the-better-one/amfora/subscriptions/subscriptions.go:76 +0x3f0

[makew0rld]

@alexsavage thanks for that output, that should be enough for me to fix this issue. Concerning it's happening even with v1.9.2. I will look into it and try to fix it tomorrow evening (March 23).

[makew0rld]

@OfekShochat @alexsavage could you answer some questions to help me understand the bug? I've been looking into it but it's tricky.

1. Does the crash occur immediately after running Amfora, or after the screen opening or some length of time?
2. Does the crash occur consistently every time you open Amfora, or somewhat randomly?

I would also appreciate if you both could share your subscriptions.json and config.toml file. On *nix those files are stored at ~/.local/share/amfora/subscriptions.json and ~/.config/amfora/config.toml. Note that your subscriptions may contain data you wish to keep private, so take a look before sharing.

This hopefully will help me track down why this is occurring. Confused at the moment.

[OfekShochat]

Instantly and consistantly. Ive just built it, no further config. I can try and gdb it which will give you more info than you're asking, though it might take some time for me (not at home). But I'm confused as you are, but I'm not that familiar with go's internals (when does it lock? When does it unlock? Why does it even unlock if it didn't lock? Afaik it doesnt schedule it like a async runtime which would make sense, somewhat, to lock on time.Sleep). It would maybe make sense on viper.getInt cuz it has to lock to get the shared(?) memory. And then if this is true, it might be a go issue.
Edit realized that gdb won't really help here

[OfekShochat]

Hmm, seems like the problem solved itself? I had many disk related issues in the last week but well idk. I'm going to leave this issue open though

[makew0rld]

Instantly and consistantly. Ive just built it, no further config.

Thanks. So sounds like you have no subscriptions and the default config. Really not sure why this is happening then.

Hmm, seems like the problem solved itself?

Wow, it no longer appears? Let me know if it comes back or if you can figure out what is causing it.

I'm going to leave this issue open though

Yes thanks. I'd like to continue debugging with @alexsavage to get this fixed.

[alexsavage]

This is on a clean user with no amfora files - here is the config.toml that got dropped. I don’t have a subscriptions.json file at all, though!
config.toml

On the “disk slow” thought - I am running on a Raspberry Pi 4, not slow but not a high end server or anything. Perhaps there is a race condition between some of the default files being created, and the startup?

[makew0rld]

Thanks for sharing your config. Of course it's just the default one because it's a fresh install, so I'm not sure if there's many clues there.

I don’t have a subscriptions.json file at all, though!

That makes sense, it's only created once you add a subscription.

I tried running Amfora v1.9.2 on my computer, no config file and no subscriptions file, and I still can't replicate this. Frustrating.

Perhaps there is a race condition between some of the default files being created, and the startup?

I don't think so, I can't see where that would happen. I guess it's possible though, and @OfekShochat did mention disk issues above.

Could you try this binary instead? Just built this myself, just want to sanity check this isn't some strange build issue. Don't expect it will be.

amfora_v1.9.2_freebsd_arm64.zip

[alexsavage]

Okay, on to something! The pkg distribution, my own build from source, and your build all run outside tmux just fine, but are crashing when run under tmux, along with tip of trunk.

Looks like when TERM=tmux-256color is when I get the crash.

asavage@pebbles ~ % amfora -v
Amfora v1.9.2
Commit: 61d8645
Built by: unknown
asavage@pebbles ~ % amfora
asavage@pebbles ~ % export TERM=tmux-256color
asavage@pebbles ~ % amfora
fatal error: sync: Unlock of unlocked RWMutex

goroutine 1 [running]:
runtime.throw({0x4ad6ab, 0x20})
        runtime/panic.go:1198 +0x54 fp=0x40001cbd60 sp=0x40001cbd30 pc=0x45fe4
sync.throw({0x4ad6ab, 0x20})
        runtime/panic.go:1184 +0x30 fp=0x40001cbd80 sp=0x40001cbd60 pc=0x73650
sync.(*RWMutex).Unlock(0x40001f0b0c)
        sync/rwmutex.go:142 +0x88 fp=0x40001cbdc0 sp=0x40001cbd80 pc=0x8c6f8
code.rocketnine.space/tslocum/cview.(*Application).Init(0x40001f0a00)
        code.rocketnine.space/tslocum/cview@v1.5.6-0.20210530175404-7e8817f20bdc/application.go:226 +0x8c fp=0x40001cbe10 sp=0x40001cbdc0 pc=0x179e1c
main.main()
        github.com/makeworld-the-better-one/amfora/amfora.go:71 +0x6ac fp=0x40001cbf70 sp=0x40001cbe10 pc=0x3d4ccc
runtime.main()
        runtime/proc.go:255 +0x284 fp=0x40001cbfd0 sp=0x40001cbf70 pc=0x48884
runtime.goexit()
        runtime/asm_arm64.s:1133 +0x4 fp=0x40001cbfd0 sp=0x40001cbfd0 pc=0x77b94

goroutine 6 [runnable]:
github.com/makeworld-the-better-one/amfora/subscriptions.(*jsonData).RUnlock(0x893780)
        github.com/makeworld-the-better-one/amfora/subscriptions/structs.go:62 +0xdc
github.com/makeworld-the-better-one/amfora/subscriptions.updateAll()
        github.com/makeworld-the-better-one/amfora/subscriptions/subscriptions.go:393 +0x108
github.com/makeworld-the-better-one/amfora/subscriptions.Init.func1()
        github.com/makeworld-the-better-one/amfora/subscriptions/subscriptions.go:78 +0x20
created by github.com/makeworld-the-better-one/amfora/subscriptions.Init
        github.com/makeworld-the-better-one/amfora/subscriptions/subscriptions.go:76 +0x3f0