Skip to content

Commit 0fa72ae

Browse files
committed
fix issues pointed by the ai reviewer
1 parent 882ebd4 commit 0fa72ae

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

src/makim/core.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -216,14 +216,13 @@ def _call_shell_app(
216216

217217
try:
218218
p.wait()
219-
# Explicitly check exit code for defense in depth
220-
returncode = getattr(p, 'returncode', None)
221-
if returncode is None or returncode != 0:
222-
error_code = returncode if returncode is not None else 1
219+
# Check exit code when available
220+
returncode = getattr(p, 'returncode', 0)
221+
if returncode != 0:
223222
MakimLogs.raise_error(
224-
f'Command exited with code {error_code}',
223+
f'Command exited with code {returncode}',
225224
MakimError.SH_ERROR_RETURN_CODE,
226-
error_code,
225+
returncode,
227226
exit_on_error=exit_on_error,
228227
)
229228
return False

0 commit comments

Comments
 (0)