Disable world exposure

[KevinGuancheDarias]

Hello, after testing the plugin, it's wonderful, love it, but I'm going to use it to allow my game to be moddable by third party people

The problem is that I can't trust people, using luau doesn't completely fix the problem, as this plugin currently exposes "world" to all scripts, and after taking a look at the great documentation, world is just "too powerful", it can alter arbitrary any part of the game, so my idea is to disable it, I would like to disable any binding unless explicitly allowed.

So I can develop my game custom mod api such as

game.add_unit(unit_descriptor)

instead of using world to directly insert an entity, modder would use my custom add_unit method for it, I already saw it's perfectly possible to create objects and functions (awesome work!), so I only need to disable world and any other potentially powerful type

⚠️ Disclaimer: I have seen there's a feature to disable globals, but I think it can't disable world

Thanks in advance 🙏 !

[makspll]

Hello! So at the moment there is no nice way to do this, but the world is set as a global in the very first context_initializer:

bevy_mod_scripting/crates/bevy_mod_scripting_core/src/context.rs

Line 34 in 040cc4a

pub context_initializers: Vec<ContextInitializer<P>>,

Removing this initializer (probably in a startup system), will prevent world from being set for the script.

If you disable the core_functions feature though, any functions registered for world will be disabled (but this includes a lot of other utilities, see:

bevy_mod_scripting/crates/bevy_mod_scripting_functions/src/core.rs

Line 1277 in 040cc4a

register_world_functions(world);

)

Another way of doing this, is invalidating the thread local which backs this value i.e. adding a context initializer which retrieves the world and then:

let world = ThreadWorldContainer.try_get_world().unwrap();
world.invalidate();

this will render ANY AND ALL accesses to the world null and void including in your own bindings. This type of hardcode invalidation is probably mostly suitable for applications in which you just don't want scripts to change anything directly.

As for a longer term solution, I should be able to make this global optional, probably by setting it through the global registry, allowing you to filter it like any other

[KevinGuancheDarias]

Good morning!

As I want to have bindings, and let the Luau interact with the game (within my specified bounds), I can't disable core_functions

This other solution

Removing this initializer (probably in a startup system), will prevent world from being set for the script.

Would still allow me to register bindings, event listeners and such features?

If that's the case, I would try to follow that path, by learning how to disable that context initializer in some bevy startup system

Thanks 🙏