fix: preserve legacy user decoding

Author: martinsander00

smartcontract/programs/doublezero-serviceability/src/state/user.rs

@@ -294,7 +294,15 @@ pub struct User {
         )
     )]
     pub feed_pks: Vec<Pubkey>, // 4 + 32 * len
-    pub accesspass_pk: Pubkey,     // 32
+    #[cfg_attr(
+        feature = "serde",
+        serde(
+            default,
+            serialize_with = "doublezero_program_common::serializer::serialize_pubkey_as_string",
+            deserialize_with = "doublezero_program_common::serializer::deserialize_pubkey_from_string"
+        )
+    )]
+    pub accesspass_pk: Pubkey, // 32
 }
 
 impl Default for User {

smartcontract/sdk/go/serviceability/state.go

@@ -988,7 +988,7 @@ type User struct {
 	BgpRttNs uint64
 	// FeedPks are the EdgeSeat Feeds whose per-feed seats this user consumed at connect (multicast
 	// only); empty for non-EdgeSeat/unicast users. A user may hold seats on multiple feeds.
-	FeedPks         [][32]byte
+	FeedPks          [][32]byte
 	AccessPassPubKey [32]byte
 	PubKey           [32]byte
 }

smartcontract/sdk/rs/src/commands/accesspass/get.rs

@@ -61,7 +61,7 @@ pub fn resolve_user_accesspass(
             Ok(AccountData::AccessPass(accesspass)) => Ok((user.accesspass_pk, accesspass)),
             Ok(_) => eyre::bail!(
                 "Recorded access pass {} for user {user_pk} has the wrong account type",
-                user.accesspass_pk
+                user.accesspass_pk,
             ),
             Err(err) => Err(err).wrap_err_with(|| {
                 format!(
@@ -310,6 +310,8 @@ mod tests {
         assert_eq!(resolved, (accesspass_pk, expected_accesspass));
     }
 
+    // Legacy users record no pass. When both possible passes exist, deletion must ask the caller
+    // to select one.
     #[test]
     fn test_resolve_user_accesspass_lists_legacy_conflict() {
         let mut client = create_test_client();
@@ -343,6 +345,7 @@ mod tests {
         assert!(message.contains("--access-pass <ADDRESS>"));
     }
 
+    // The caller resolves a legacy conflict by selecting either matching pass explicitly.
     #[test]
     fn test_resolve_user_accesspass_selects_legacy_candidate() {
         let mut client = create_test_client();