Skip to content

Go decoders should assert against testdata/golden vectors #48

Description

@armcconnell

The golden vectors added in #45 are meant to be the cross-language contract, but grep -rn testdata/golden go/ returns nothing — only the Rust crates assert against them, so the Go decoders can drift without CI noticing. The README was narrowed in 4dbac55 to say so rather than overstate it.

To close it: have each parser decode the relevant .bin vectors and assert the field values in manifest.json, and add a testdata/golden/** path trigger to go-tests.yml. The Wireshark dissectors have the same gap.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions