Skip to content

Commit 039f470

Browse files
authored
fix: reduce log noise for missing deployments in variant filtering (llm-d#805)
Signed-off-by: Guangya Liu <gyliu513@gmail.com>
1 parent 49946fa commit 039f470

1 file changed

Lines changed: 14 additions & 1 deletion

File tree

internal/utils/variant.go

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import (
2020
"context"
2121

2222
appsv1 "k8s.io/api/apps/v1"
23+
apierrors "k8s.io/apimachinery/pkg/api/errors"
2324
ctrl "sigs.k8s.io/controller-runtime"
2425
"sigs.k8s.io/controller-runtime/pkg/client"
2526

@@ -132,7 +133,19 @@ func filterVariantsByDeployment(ctx context.Context, client client.Client, filte
132133
deployName := va.Spec.ScaleTargetRef.Name
133134
var deploy appsv1.Deployment
134135
if err := GetDeploymentWithBackoff(ctx, client, deployName, va.Namespace, &deploy); err != nil {
135-
ctrl.LoggerFrom(ctx).Error(err, "Failed to get deployment", "namespace", va.Namespace, "deploymentName", deployName, "vaName", va.Name)
136+
if apierrors.IsNotFound(err) {
137+
// Deployment doesn't exist yet, this is expected for VAs without corresponding deployments
138+
ctrl.LoggerFrom(ctx).V(logging.DEBUG).Info("Deployment not found for VariantAutoscaling, skipping",
139+
"namespace", va.Namespace,
140+
"deploymentName", deployName,
141+
"vaName", va.Name)
142+
} else {
143+
// Unexpected error (permissions, network issues, etc.)
144+
ctrl.LoggerFrom(ctx).Error(err, "Failed to get deployment",
145+
"namespace", va.Namespace,
146+
"deploymentName", deployName,
147+
"vaName", va.Name)
148+
}
136149
continue
137150
}
138151

0 commit comments

Comments
 (0)