Skip to content

Commit 232a0d8

Browse files
ev-shindinmamy-CS
authored andcommitted
fix(test): increase in-cluster scraping job timeout to 5 minutes
The curlimages/curl image must be pulled from Docker Hub at runtime inside the Kind cluster. GitHub Actions shared runner IPs are frequently rate-limited by Docker Hub, causing image pulls to exceed the previous 2-minute timeout. Increase to 5 minutes to account for slow image pulls in CI.
1 parent da65866 commit 232a0d8

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

test/utils/pod_scraping_test_helpers.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -532,12 +532,14 @@ func TestInClusterScraping(ctx context.Context, config PodScrapingTestConfig, g
532532
}()
533533

534534
// Wait for job to complete
535+
// Timeout must account for image pull time (curlimages/curl may need to be pulled from Docker Hub,
536+
// which can be slow in CI due to rate limiting on shared GitHub Actions runner IPs)
535537
_, _ = fmt.Fprintf(ginkgo.GinkgoWriter, "Waiting for in-cluster scraping test job to complete...\n")
536538
gom.Eventually(func(g gom.Gomega) {
537539
currentJob, err := config.K8sClient.BatchV1().Jobs(config.ServiceNamespace).Get(ctx, jobName, metav1.GetOptions{})
538540
g.Expect(err).NotTo(gom.HaveOccurred(), "Should be able to get job")
539541
g.Expect(currentJob.Status.Succeeded+currentJob.Status.Failed).To(gom.BeNumerically(">", 0), "Job should complete")
540-
}, 2*time.Minute, 5*time.Second).Should(gom.Succeed())
542+
}, 5*time.Minute, 5*time.Second).Should(gom.Succeed())
541543

542544
// Verify job succeeded
543545
finalJob, err := config.K8sClient.BatchV1().Jobs(config.ServiceNamespace).Get(ctx, jobName, metav1.GetOptions{})

0 commit comments

Comments
 (0)