Skip to content

Commit 0520427

Browse files
committed
Also conditionally define GLOG_USE_GLOG_EXPORT on Windows
Signed-off-by: Julien Jerphanion <[email protected]>
1 parent 7f44c50 commit 0520427

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

cpp/CMakeLists.txt

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,12 @@ if(ARCTICDB_SANITIZER_FLAGS)
7474
message(STATUS "Building ArcticDB with sanitizers. Compiler flags: ${ARCTICDB_SANITIZER_FLAGS}")
7575
endif()
7676

77+
if(${ARCTICDB_USING_CONDA})
78+
# Required to be able to include headers from glog since glog 0.7
79+
# See: https://github.com/google/glog/pull/1030
80+
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DGLOG_USE_GLOG_EXPORT")
81+
endif()
82+
7783
if(WIN32)
7884
add_compile_definitions(
7985
NOGDI WIN32_LEAN_AND_MEAN HAVE_SNPRINTF NOMINMAX
@@ -96,9 +102,7 @@ if(WIN32)
96102
endif()
97103
else()
98104
if(${ARCTICDB_USING_CONDA})
99-
# Required to be able to include headers from glog since glog 0.7
100-
# See: https://github.com/google/glog/pull/1030
101-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wextra -DGLOG_USE_GLOG_EXPORT")
105+
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wextra")
102106
else()
103107
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra")
104108
endif()

0 commit comments

Comments
 (0)