Skip to content

Commit 080db00

Browse files
authored
when workflow executed on schedule run all tests (#2205)
#### Reference Issues/PRs <!--Example: Fixes #1234. See also #3456.--> Added new option ALL to execute both real storage and lmdb tests. Tested manualy - execution link: https://github.com/man-group/ArcticDB/actions/runs/13543308725/job/37849144845 #### What does this implement or fix? #### Any other comments? #### Checklist <details> <summary> Checklist for code changes... </summary> - [ ] Have you updated the relevant docstrings, documentation and copyright notice? - [ ] Is this contribution tested against [all ArcticDB's features](../docs/mkdocs/docs/technical/contributing.md)? - [ ] Do all exceptions introduced raise appropriate [error messages](https://docs.arcticdb.io/error_messages/)? - [ ] Are API changes highlighted in the PR description? - [ ] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes? </details> <!-- Thanks for contributing a Pull Request to ArcticDB! Please ensure you have taken a look at: - ArcticDB's Code of Conduct: https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md - ArcticDB's Contribution Licensing: https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing --> --------- Co-authored-by: Georgi Rusev <Georgi Rusev>
1 parent 509fa08 commit 080db00

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

.github/workflows/analysis_workflow.yml

+3-2
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,12 @@ on:
1010
type: string
1111
default: latest
1212
suite_to_run:
13-
description: Run LMDB suite or REAL storage
13+
description: Run LMDB suite or REAL storage (or both - ALL)
1414
type: choice
1515
options:
1616
- 'LMDB'
1717
- 'REAL'
18+
- 'ALL'
1819
default: 'LMDB'
1920
suite_overwrite:
2021
description: Specify regular expression for specific tests to be executed
@@ -63,7 +64,7 @@ jobs:
6364
run_all_benchmarks: ${{ inputs.run_all_benchmarks || false }}
6465
run_on_pr_head: ${{ github.event_name == 'pull_request_target' }}
6566
dev_image_tag: ${{ inputs.dev_image_tag || 'latest' }}
66-
suite_to_run: ${{ inputs.suite_to_run || 'LMDB'}}
67+
suite_to_run: ${{ github.event_name == 'schedule' && 'ALL' || inputs.suite_to_run || 'LMDB'}}
6768
suite_overwrite: ${{ inputs.suite_overwrite || ''}}
6869

6970
publish_benchmark_results_to_gh_pages:

.github/workflows/benchmark_commits.yml

+4-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66
commit: {required: true, type: string, description: commit hash that will be benchmarked}
77
run_on_pr_head: {required: false, default: false, type: boolean, description: Specifies if the benchmark should run on PR head branch}
88
dev_image_tag: {required: false, default: 'latest', type: string, description: Tag of the ArcticDB development image}
9-
suite_to_run: {required: true, type: string, default: 'LMDB', description: Default benchmark on 'LMDB' storage (or 'REAL' storage)}
9+
suite_to_run: {required: true, type: string, default: 'LMDB', description: Default benchmark on 'LMDB' storage (or 'REAL' storage ond 'ALL' for both)}
1010
suite_overwrite: {required: false, type: string, default: '', description: User defined tests to run}
1111
jobs:
1212
start_ec2_runner:
@@ -74,11 +74,13 @@ jobs:
7474
pip install asv virtualenv
7575
python -m asv machine -v --yes --machine ArcticDB-Medium-Runner
7676
77-
- name: Confugure what suite or tests to execute
77+
- name: Configure what suite or tests to execute
7878
shell: bash -el {0}
7979
run: |
8080
if [ "${{ github.event.inputs.suite_to_run }}" == "REAL" ]; then
8181
SUITE='^(real_).*'
82+
elif [ "${{ github.event.inputs.suite_to_run }}" == "ALL" ]; then
83+
SUITE='^.*'
8284
else
8385
SUITE='^(?!real_).*'
8486
fi

0 commit comments

Comments
 (0)