More logging for the DecodeSegmentTask (#2796)

Author: ognyanstoimenov

cpp/arcticdb/async/tasks.hpp

@@ -422,17 +422,23 @@ struct DecodeSegmentTask : BaseTask {
 
     DecodeSegmentTask() = default;
 
-    std::pair<VariantKey, SegmentInMemory> operator()(storage::KeySegmentPair&& ks) const {
+    std::pair<VariantKey, SegmentInMemory> operator()(storage::KeySegmentPair&& key_segment) const {
         ARCTICDB_SAMPLE(DecodeAtomTask, 0)
 
-        auto key_seg = std::move(ks);
         ARCTICDB_DEBUG(
                 log::storage(),
                 "ReadAndDecodeAtomTask decoding segment with key {}",
-                variant_key_view(key_seg.variant_key())
+                variant_key_view(key_segment.variant_key())
         );
 
-        return {key_seg.variant_key(), decode_segment(*key_seg.segment_ptr())};
+        try {
+            auto decoded_segment = decode_segment(*key_segment.segment_ptr());
+            return {std::move(key_segment).variant_key(), std::move(decoded_segment)};
+        } catch (const std::exception& e) {
+            codec::raise<ErrorCode::E_DECODE_ERROR>(
+                    "DecodeSegmentTask failed for key {}: {}", variant_key_view(key_segment.variant_key()), e.what()
+            );
+        }
     }
 };
 

cpp/arcticdb/codec/lz4.hpp

@@ -74,15 +74,15 @@ struct Lz4Decoder {
         const int decompressed_size = LZ4_decompress_safe(
                 reinterpret_cast<const char*>(in), reinterpret_cast<char*>(t_out), int(in_bytes), int(out_bytes)
         );
-        util::check_arg(
+        codec::check<ErrorCode::E_DECODE_ERROR>(
                 decompressed_size >= 0,
                 "Error while decoding with lz4 at address {:x} with size {}. Code {}",
                 uintptr_t(in),
                 in_bytes,
                 decompressed_size
         );
 
-        util::check_arg(
+        codec::check<ErrorCode::E_DECODE_ERROR>(
                 std::size_t(decompressed_size) == out_bytes,
                 "expected out_bytes == lz4 decompressed bytes, actual {} != {}",
                 out_bytes,