Use older msvc

Author: Vasil Pashov

.github/workflows/build_steps.yml

@@ -124,16 +124,6 @@ jobs:
         run: |
           choco install -y -f visualstudio2022buildtools --version=117.11.4 --params "--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64 --installChannelUri https://aka.ms/vs/17/release/390666095_1317821361/channel"
           choco install visualstudio2022-workload-vctools -y
-          ls "C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools"
-          ls "C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools\\VC"
-          ls "C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools\\VC\\Tools"
-          ls "C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools\\VC\\Tools\\MSVC"
-          ls "C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools\\VC\\Tools\\MSVC\\14.41.34120"
-          ls "C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools\\VC\\Tools\\MSVC\\14.41.34120\\bin"
-          ls "C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools\\VC\\Tools\\MSVC\\14.41.34120\\bin\\Hostx64"
-          ls "C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools\\VC\\Tools\\MSVC\\14.41.34120\\bin\\Hostx64\\x64"
-
-      - uses: lukka/get-cmake@latest
 
       - name: Enable Windows compiler commands
         if: matrix.os == 'windows'
@@ -145,42 +135,20 @@ jobs:
           export-path-to-vcvarsall: 'VSVARS_ALL_PATH'
           export-path-to-vs: 'VISUAL_STUDIO_PATH'
 
-      - name: Print VS Variables
-        if: matrix.os == 'windows'
-        run: |
-          echo "$VSVARS_ALL_PATH"
-          echo "$VISUAL_STUDIO_PATH"
-          ls "$VSVARS_ALL_PATH"
-
-      - name: Prepend to path
-        run: |
-          echo -e "C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools\\VC\\Tools\\MSVC\\14.41.34120\\bin\\Hostx64\\x64\n$(cat $GITHUB_PATH)" > $GITHUB_PATH
-
       - name: CMake compile
         if: inputs.job_type != 'build-python-wheels'
         # We are pinning the version to 10.6 because >= 10.7, use node20 which is not supported in the container
         uses: lukka/[email protected]
-        env:
-            CXX: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools\\VC\\Tools\\MSVC\\14.41.34120\\bin\\Hostx64\\x64\\cl.exe"
-            CC: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools\\VC\\Tools\\MSVC\\14.41.34120\\bin\\Hostx64\\x64\\cl.exe"
-            CMAKE_CXX_COMPILER: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools\\VC\\Tools\\MSVC\\14.41.34120\\bin\\Hostx64\\x64\\cl.exe"
-            CMAKE_C_COMPILER: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools\\VC\\Tools\\MSVC\\14.41.34120\\bin\\Hostx64\\x64\\cl.exe"
         with:
           cmakeListsTxtPath: ${{github.workspace}}/cpp/CMakeLists.txt
           configurePreset: ${{env.ARCTIC_CMAKE_PRESET}}
-          configurePresetAdditionalArgs: "['-DVCPKG_INSTALL_OPTIONS=--clean-after-build', '-DCMAKE_CXX_COMPILER=\"C:/Program Files (x86)/Microsoft Visual Studio/2022/BuildTools/VC/Tools/MSVC/14.41.34120/bin/Hostx64/x64/cl.exe\"', '-DVCPKG_PLATFORM_TOOLSET_VERSION=\"14.41\"']"
+          configurePresetAdditionalArgs: "['-DVCPKG_INSTALL_OPTIONS=--clean-after-build']"
           buildPreset: ${{env.ARCTIC_CMAKE_PRESET}}
 
       - name: CMake compile
         if: inputs.job_type == 'build-python-wheels'
-        env:
-            CXX: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools\\VC\\Tools\\MSVC\\14.41.34120\\bin\\Hostx64\\x64\\cl.exe"
-            CC: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools\\VC\\Tools\\MSVC\\14.41.34120\\bin\\Hostx64\\x64\\cl.exe"
-            CMAKE_CXX_COMPILER: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools\\VC\\Tools\\MSVC\\14.41.34120\\bin\\Hostx64\\x64\\cl.exe"
-            CMAKE_C_COMPILER: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools\\VC\\Tools\\MSVC\\14.41.34120\\bin\\Hostx64\\x64\\cl.exe"
         working-directory: ${{github.workspace}}/cpp
         run: |
-          "./vcpkg/bootstrap-vcpkg.bat"
           "$VSVARS_ALL_PATH/vcvars64.bat"
           cmake --preset ${{env.ARCTIC_CMAKE_PRESET}} -DCMAKE_CXX_COMPILER="${{env.CXX}}"